improvement(Move uptime check into TripPlannerVersion enum):

Author: br648

src/main/java/com/conveyal/datatools/manager/jobs/MonitorServerStatusJob.java

@@ -136,7 +136,7 @@ public void jobLogic() {
             // become available.
             TimeTracker routerCheckTracker = new TimeTracker(20, TimeUnit.MINUTES);
 
-            String routerUrl = String.join("/", ipUrl, deployment.tripPlannerVersion.equals(TripPlannerVersion.OTP_2) ? "otp/actuators/health" : "otp/routers/default");
+            String routerUrl = String.join("/", ipUrl, TripPlannerVersion.getUptimeCheckUrl(deployment.tripPlannerVersion));
             boolean routerIsAvailable = false;
             while (!routerIsAvailable) {
                 // If the request was successful, the graph build is complete!

src/main/java/com/conveyal/datatools/manager/models/Deployment.java

@@ -666,7 +666,18 @@ public boolean boundsAreValid () {
     }
 
     public enum TripPlannerVersion {
-        OTP_1, OTP_2
+        OTP_1("otp/routers/default"),
+        OTP_2("otp/actuators/health");
+
+        private final String uptimeCheckUrl;
+
+        TripPlannerVersion(String uptimeCheckUrl) {
+            this.uptimeCheckUrl = uptimeCheckUrl;
+        }
+
+        public static String getUptimeCheckUrl(TripPlannerVersion version) {
+            return (version == OTP_2) ? OTP_2.uptimeCheckUrl : OTP_1.uptimeCheckUrl;
+        }
     }
 
     /**