Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always propagate profile to individual pipelines' stages when instantiating a DistributionMaker or Detectors instance #815

Closed
thehrh opened this issue Aug 23, 2024 · 1 comment · Fixed by #822
Assignees

Comments

@thehrh
Copy link
Contributor

thehrh commented Aug 23, 2024

Documenting before making a PR....

  • when a DistributionMaker is created from an instanstiated Pipeline, profile is silently ignored. Instead, we should enforce pipeline.profile = profile (below
    pipeline = Pipeline(pipeline, profile=profile)
    : else: pipeline.profile = profile)
  • this will also correctly propagate profile when constructing a Detectors instance:
    profile=profile

Also, it would be convenient for both DistributionMaker and Detectors to also have a report_profile method, allowing us to profile all included pipelines at once. This would just iterate over pipelines (and print each name) respectively distribution_makers (same) and call the associated report_profile.

@thehrh
Copy link
Contributor Author

thehrh commented Aug 23, 2024

Note, the above will not allow profiling setup of a pipeline originally instantiated with profile=False though, since the pipeline init already runs setup for each stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant