Code refactor for Ruby style

Author: Kemal AKIN

lib/ilkbyte.rb

@@ -1,35 +1,38 @@
-require "ilkbyte/version"
+# frozen_string_literal: true
+
+require 'ilkbyte/version'
 require 'httpclient'
 require 'json'
 
 module Ilkbyte
   class Error < StandardError; end
   class Base
-    $baseUrl = "https://api.ilkbyte.com"
-    def setOption(access,secret)
-      $option = {"access" => access,"secret" => secret}
+    $baseUrl = 'https://api.ilkbyte.com'
+    def setOption(access, secret)
+      $option = { 'access' => access, 'secret' => secret }
     end
+
     def request(url = nil, param = {})
-      @query = {"access" => $option["access"],"secret" => $option["secret"]}
-      param.each do |key,value|
-        @query.store(key,value)
+      @query = { 'access' => $option['access'], 'secret' => $option['secret'] }
+      param.each do |key, value|
+        @query.store(key, value)
       end
       apiUrl = $baseUrl + url
       begin
         client = HTTPClient.new
-        response = client.get(apiUrl,@query)
+        response = client.get(apiUrl, @query)
         JSON.parse(response.body)
-      rescue StandardError => e  
+      rescue StandardError => e
         response = {
-          "status" => false,
-          "response" => nil,
-          "message" => e.message
-        }    
+          'status' => false,
+          'response' => nil,
+          'message' => e.message
+        }
       end
     end
   end
 end
 
 require_relative 'ilkbyte/server'
 require_relative 'ilkbyte/domain'
-require_relative 'ilkbyte/account'
+require_relative 'ilkbyte/account'

lib/ilkbyte/account.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module Ilkbyte
   class Account < Base
-    def account()
-      request("/account")
+    def account
+      request('/account')
     end
 
-    def accountUsers()
-      request("/account/users")
+    def accountUsers
+      request('/account/users')
     end
   end
-end
+end

lib/ilkbyte/domain.rb

@@ -1,23 +1,25 @@
+# frozen_string_literal: true
+
 module Ilkbyte
   class Domain < Base
-    def all()
-      request("/domain/list")
+    def all
+      request('/domain/list')
     end
 
     def create(query)
-      request("/domain/create",query)
+      request('/domain/create', query)
     end
 
     def show(domain)
       request("/domain/manage/#{domain}/show")
     end
 
-    def add(domain,query)
-      request("/domain/manage/#{domain}/add",query)
+    def add(domain, query)
+      request("/domain/manage/#{domain}/add", query)
     end
 
-    def update(domain,query)
-      request("/domain/manage/#{domain}/uptade",query)
+    def update(domain, query)
+      request("/domain/manage/#{domain}/uptade", query)
     end
 
     def delete(domain)
@@ -28,4 +30,4 @@ def push(domain)
       request("/domain/manage/#{domain}/push")
     end
   end
-end
+end

lib/ilkbyte/server.rb

@@ -1,40 +1,42 @@
+# frozen_string_literal: true
+
 module Ilkbyte
   class Server < Base
-    def create()
-      request("/server/create")
+    def create
+      request('/server/create')
     end
 
     def config(query)
-      request("/server/create/config",query)
+      request('/server/create/config', query)
     end
 
-    def all()
-      request("/server/list/all")
+    def all
+      request('/server/list/all')
     end
 
-    def active()
-      request("/server/list")
+    def active
+      request('/server/list')
     end
 
     def show(server_name)
       request("/server/manage/#{server_name}/show")
     end
 
-    def power(server_name,power)
-      query = {"set" => power}
-      request("/server/manage/#{server_name}/power",query)
+    def power(server_name, power)
+      query = { 'set' => power }
+      request("/server/manage/#{server_name}/power", query)
     end
 
     def monitor(server_name)
       request("/server/manage/#{server_name}/monitor")
     end
 
-    def ipRdns(server_name,ip,rdns)
+    def ipRdns(server_name, ip, rdns)
       query = [
-        "ip" => ip,
-        "rdns" => rdns
+        'ip' => ip,
+        'rdns' => rdns
       ]
-      request("/server/manage/#{server_name}/ip/rdns",query)
+      request("/server/manage/#{server_name}/ip/rdns", query)
     end
 
     def ip(server_name)
@@ -49,36 +51,36 @@ def backup(server_name)
       request("/server/manage/#{server_name}/backup")
     end
 
-    def backupRestore(server_name,query)
-      request("/server/manage/#{server_name}/backup/restore",query)
+    def backupRestore(server_name, query)
+      request("/server/manage/#{server_name}/backup/restore", query)
     end
 
     def snapshot(server_name)
       request("/server/manage/#{server_name}/snapshot")
     end
 
-    def snapshotCreate(server_name,query)
-      request("/server/manage/#{server_name}/snapshot/create",query)
+    def snapshotCreate(server_name, query)
+      request("/server/manage/#{server_name}/snapshot/create", query)
     end
 
-    def snapshotRevert(server_name,query)
-      request("/server/manage/#{server_name}/snapshot/revert",query)
+    def snapshotRevert(server_name, query)
+      request("/server/manage/#{server_name}/snapshot/revert", query)
     end
 
-    def snapshotUpdate(server_name,query)
-      request("/server/manage/#{server_name}/snapshot/update",query)
+    def snapshotUpdate(server_name, query)
+      request("/server/manage/#{server_name}/snapshot/update", query)
     end
 
-    def snapshotDelete(server_name,query)
-      request("/server/manage/#{server_name}/snapshot/delete",query)
+    def snapshotDelete(server_name, query)
+      request("/server/manage/#{server_name}/snapshot/delete", query)
     end
 
-    def snapshotCronAdd(server_name,query)
-      request("/server/manage/#{server_name}/snapshot/cron/add",query)
+    def snapshotCronAdd(server_name, query)
+      request("/server/manage/#{server_name}/snapshot/cron/add", query)
     end
 
-    def snapshotCronDelete(server_name,query)
-      request("/server/manage/#{server_name}/snapshot/cron/delete",query)
+    def snapshotCronDelete(server_name, query)
+      request("/server/manage/#{server_name}/snapshot/cron/delete", query)
     end
-  end   
-end
+  end
+end

lib/ilkbyte/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ilkbyte
-  VERSION = "0.2.1"
+  VERSION = '0.2.1'
 end