You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, both open and closed, to make sure this is not a duplicate report.
Yes
The bug
The memories page contains a gallery of all photos at the bottom of the page (if you scroll down). This gallery should also support selection of photos (clicking the checkbox), both via mouse and keyboard. At first glance this appears to work, however if you select a photo, but then hit next/previous in the memory view above, the selection in the gallery is cleared. However, at the top of the page the selection dialog remains. You can then also hit select again at the bottom of the same photo and the dialog at the top will count it twice!
The OS that Immich Server is running on
Ubuntu 24.04.2 LTS (but will affect any)
Version of Immich Server
V1.129.0
Version of Immich Mobile App
N/A
Platform with the issue
Server
Web
Mobile
Your docker-compose.yml content
## WARNING: Make sure to use the docker-compose.yml of the current release:## https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml## The compose file on main may not be compatible with the latest release.#name: immichservices:
immich-server:
container_name: immich_serverimage: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}extends:
file: hwaccel.transcoding.ymlservice: quicksync # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcodingvolumes:
# Do not edit the next line. If you want to change the media storage location on your system, edit the value of UPLOAD_LOCATION in the .env file
- ${UPLOAD_LOCATION}:/usr/src/app/upload
- /etc/localtime:/etc/localtime:roenv_file:
- .envports:
- '2283:2283'depends_on:
- redis
- databaserestart: alwayshealthcheck:
disable: falseimmich-machine-learning:
container_name: immich_machine_learning# For hardware acceleration, add one of -[armnn, cuda, openvino] to the image tag.# Example tag: ${IMMICH_VERSION:-release}-cudaimage: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}# extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/ml-hardware-acceleration# file: hwaccel.ml.yml# service: cpu # set to one of [armnn, cuda, openvino, openvino-wsl] for accelerated inference - use the `-wsl` version for WSL2 where applicablevolumes:
- model-cache:/cacheenv_file:
- .envrestart: alwayshealthcheck:
disable: falseredis:
container_name: immich_redisimage: docker.io/redis:6.2-alpine@sha256:eaba718fecd1196d88533de7ba49bf903ad33664a92debb24660a922ecd9cac8healthcheck:
test: redis-cli ping || exit 1restart: alwaysdatabase:
container_name: immich_postgresimage: docker.io/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0environment:
POSTGRES_PASSWORD: ${DB_PASSWORD}POSTGRES_USER: ${DB_USERNAME}POSTGRES_DB: ${DB_DATABASE_NAME}POSTGRES_INITDB_ARGS: '--data-checksums'volumes:
# Do not edit the next line. If you want to change the database storage location on your system, edit the value of DB_DATA_LOCATION in the .env file
- ${DB_DATA_LOCATION}:/var/lib/postgresql/datahealthcheck:
test: >- pg_isready --dbname="$${POSTGRES_DB}" --username="$${POSTGRES_USER}" || exit 1; Chksum="$$(psql --dbname="$${POSTGRES_DB}" --username="$${POSTGRES_USER}" --tuples-only --no-align --command='SELECT COALESCE(SUM(checksum_failures), 0) FROM pg_stat_database')"; echo "checksum failure count is $$Chksum"; [ "$$Chksum" = '0' ] || exit 1interval: 5mstart_interval: 30sstart_period: 5mcommand: >- postgres -c shared_preload_libraries=vectors.so -c 'search_path="$$user", public, vectors' -c logging_collector=on -c max_wal_size=2GB -c shared_buffers=512MB -c wal_compression=onrestart: alwaysvolumes:
model-cache:
Your .env content
# You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables# The location where your uploaded files are stored
UPLOAD_LOCATION=./library
# The location where your database files are stored
DB_DATA_LOCATION=./postgres
# To set a timezone, uncomment the next line and change Etc/UTC to a TZ identifier from this list: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones#List# TZ=Etc/UTC# The Immich version to use. You can pin this to a specific version like "v1.71.0"
IMMICH_VERSION=release
# Connection secret for postgres. You should change it to a random password# Please use only the characters `A-Za-z0-9`, without special characters or spaces
DB_PASSWORD=<REDACTED># The values below this line do not need to be changed###################################################################################
DB_USERNAME=<REDACTED>
DB_DATABASE_NAME=immich
Reproduction steps
Go to a memory with multiple photos
Scroll to bottom of page where the gallery is
Select a photo (note the dialog at top shows '1 selected')
Got back to top and hit right or left to go to next/previous photo of memory
Now the selection at the bottom has cleared. Dialog shows '1 selected' still
You can select the same photo again and the dialog at the top now shows 2 selected.
Relevant log output
Additional information
I believe this is due to the fact that AssetInteraction.selectedAssets is storying a set of mutable asset proxies. Somehow due to how the memories next/previous works, it loads up a new asset proxy for the same photo, that isn't identical to the asset proxy already stored in the AssetInteraction set.
I'll look into a fix, but I think it would be better if the asset interaction would just store immutable asset ids, instead of mutable asset proxies.
The text was updated successfully, but these errors were encountered:
I have searched the existing issues, both open and closed, to make sure this is not a duplicate report.
The bug
The memories page contains a gallery of all photos at the bottom of the page (if you scroll down). This gallery should also support selection of photos (clicking the checkbox), both via mouse and keyboard. At first glance this appears to work, however if you select a photo, but then hit next/previous in the memory view above, the selection in the gallery is cleared. However, at the top of the page the selection dialog remains. You can then also hit select again at the bottom of the same photo and the dialog at the top will count it twice!
The OS that Immich Server is running on
Ubuntu 24.04.2 LTS (but will affect any)
Version of Immich Server
V1.129.0
Version of Immich Mobile App
N/A
Platform with the issue
Your docker-compose.yml content
Your .env content
Reproduction steps
Relevant log output
Additional information
I believe this is due to the fact that AssetInteraction.selectedAssets is storying a set of mutable asset proxies. Somehow due to how the memories next/previous works, it loads up a new asset proxy for the same photo, that isn't identical to the asset proxy already stored in the AssetInteraction set.
I'll look into a fix, but I think it would be better if the asset interaction would just store immutable asset ids, instead of mutable asset proxies.
The text was updated successfully, but these errors were encountered: