Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we support running pre ci on stacked PR? #17233

Open
AllanZyne opened this issue Feb 28, 2025 · 2 comments
Open

Can we support running pre ci on stacked PR? #17233

AllanZyne opened this issue Feb 28, 2025 · 2 comments
Labels
enhancement New feature or request infrastructure

Comments

@AllanZyne
Copy link
Contributor

AllanZyne commented Feb 28, 2025

Is your feature request related to a problem? Please describe

Such as: #17180
If we support stacked PR workflow, we can make the code changes in each PR relatively small, which is good for code review and faster development.

Describe the solution you would like

Automatically trigger CI on PR that doesn't merge into "sycl" branch.

@AllanZyne AllanZyne added the enhancement New feature or request label Feb 28, 2025
@aelovikov-intel
Copy link
Contributor

IIUC, you're asking to remove this filtering:

pull_request:
branches:
- sycl
- sycl-rel-**

I'm not sure if that's a good idea. Maybe we have a convention that such PRs/branches should be named stacked-pr-**, then we can extend the filter (or maybe enable-precommit-**, or some other explicit pattern).

@AllanZyne
Copy link
Contributor Author

AllanZyne commented Mar 28, 2025

It sounds good to have a PR naming pattern for stacked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants