fix(cli): return a non-zero exit code on failure #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this script would silently fail when an error was encountered. This breaks builds. Now, it will return an exit code of 1 when an error is encountered. BREAKING CHANGE: This may lead to builds that previously succeeded breaking. This would mean that there was previously an uncaught error in your setup. Well-configured, healthy builds should remain unaffected.
MatthewZaso
approved these changes
Dec 2, 2019
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this script would silently fail when an error was encountered. This breaks builds. Now,
it will return an exit code of 1 when an error is encountered.
BREAKING CHANGE: This may lead builds to break that previously succeeded. This would mean that there was previously an uncaught error in your setup. Well-configured, healthy builds should remain unaffected.