Skip to content

Add apostrophe support #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukethacoder opened this issue May 18, 2020 · 3 comments · Fixed by #98
Closed

Add apostrophe support #34

lukethacoder opened this issue May 18, 2020 · 3 comments · Fixed by #98
Labels

Comments

@lukethacoder
Copy link

image

Ran into a small bump in the road attempting to pull when using apostrophes in Contentful schemas.

Could we use backticks as opposed to apostrophes in auto generated .d.ts file? This would allow for apostrophes in the schema.

@stevenpetryk
Copy link
Contributor

I like that. But backticks could pose the same threat. Instead, I’ll make sure quotes are escaped properly.

@greym0uth
Copy link
Contributor

greym0uth commented Sep 10, 2021

I made a PR on this, the problem with just using backticks here is that its based on the project's prettier config, so it'll reformat to use either double quotes or single quotes. The solution I proposed should work with whatever prettier configuration a project is using.

@intercom-mr-updater
Copy link
Member

🎉 This issue has been resolved in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants