Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Commit ba56d84

Browse files
alanshawdryajov
authored andcommitted
fix: adds missing breaking changes for 0.29 to changelog (#1370)
1 parent 3a55461 commit ba56d84

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

CHANGELOG.md

+10-4
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,16 @@
5353

5454
### BREAKING CHANGES
5555

56-
* pubsub.unsubscribe is now async and argument order for pubsub.subscribe has changed
57-
58-
License: MIT
59-
Signed-off-by: Alan Shaw <alan@tableflip.io>
56+
1. Argument order for `pubsub.subscribe` has changed:
57+
* Old: `pubsub.subscribe(topic, [options], handler, [callback]): Promise`
58+
* New: `pubsub.subscribe(topic, handler, [options], [callback]): Promise`
59+
2. The `pubsub.unsubscribe` method has become async meaning that it now takes a callback or returns a promise:
60+
* Old: `pubsub.unsubscribe(topic, handler): undefined`
61+
* New: `pubsub.unsubscribe(topic, handler, [callback]): Promise`
62+
3. Property names on response objects for `ping` are now lowered:
63+
* Old: `{ Success, Time, Text }`
64+
* New: `{ success, time, text }`
65+
4. In the CLI, `jsipfs object data` no longer returns a newline after the end of the returned data
6066

6167

6268

0 commit comments

Comments
 (0)