extract Translator

Author: red-avtovo

src/com/j0rsa/labot/client/Skyeng.kt

@@ -1,6 +1,7 @@
 package com.j0rsa.labot.client
 
 import com.j0rsa.labot.client.support.Google
+import com.j0rsa.labot.client.support.Translator
 import com.j0rsa.labot.ktor.SetCookie
 import com.j0rsa.labot.loggerFor
 import io.ktor.client.HttpClient
@@ -266,7 +267,11 @@ class Skyeng(
                 )
             }
 
-            suspend fun toAnkiClozeNote(deckName: String, voice: Voice = Voice.Male2) = examples.map {
+            suspend fun toAnkiClozeNote(
+                deckName: String,
+                voice: Voice = Voice.Male2,
+                translator: Translator = Google
+            ) = examples.map {
                 val cWrappedExample = (it.text ?: return@map null).replace("[", "{{c1::").replace("]", "}}")
                 val clearExample = it.text.replace("[", "").replace("]", "")
                 val wordSoundAttachment = customSoundAttachment(voice) ?: return@map null
@@ -276,7 +281,7 @@ class Skyeng(
                     |$cWrappedExample<br/>
                     |- <b>${translation.text}</b><br/>
                     |{{c1::[sound:${wordSoundAttachment.filename}]}}<br/>
-                    |${Google.translateEnToRu(clearExample)}<br/>
+                    |${translator.translateEnToRu(clearExample)}<br/>
                     |{{c1::[sound:${sentenceSoundAttachment.filename}]}}<br/>
                     |{{c1::<img src='${pictureAttachment.filename}'/>}}
                 """.trimMargin()

src/com/j0rsa/labot/client/support/Google.kt

@@ -6,10 +6,14 @@ import io.ktor.client.request.get
 import io.ktor.client.request.parameter
 import io.ktor.client.statement.bodyAsText
 
-object Google {
+interface Translator {
+    suspend fun translateEnToRu(text: String): String
+}
+
+object Google : Translator {
     private val client = HttpClient(CIO)
 
-    suspend fun translateEnToRu(text: String) =
+    override suspend fun translateEnToRu(text: String) =
         client.get("https://translate.googleapis.com/translate_a/single") {
             parameter("client", "gtx")
             parameter("sl", "en")

test/com/j0rsa/labot/client/GoogleTest.kt

@@ -2,11 +2,15 @@ package com.j0rsa.labot.client
 
 import com.j0rsa.labot.client.support.Google
 import io.kotest.core.spec.style.StringSpec
+import io.kotest.matchers.collections.shouldBeOneOf
 import io.kotest.matchers.shouldBe
 
 class GoogleTest : StringSpec({
 
     "translate" {
-        Google.translateEnToRu("Some example") shouldBe "Какой-то пример"
+        Google.translateEnToRu("Some example") shouldBeOneOf listOf(
+            "Какой-то пример",
+            "Некоторый пример",
+        )
     }
 })

test/com/j0rsa/labot/client/SkyengTest.kt

@@ -2,6 +2,7 @@ package com.j0rsa.labot.client
 
 import com.j0rsa.labot.AppConfig
 import com.j0rsa.labot.client.Skyeng.Companion.Voice
+import com.j0rsa.labot.client.support.Translator
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.matchers.ints.shouldBeGreaterThanOrEqual
 import io.kotest.matchers.shouldBe
@@ -106,6 +107,10 @@ class SkyengTest : StringSpec({
     }
 
     "to anki cloze note" {
+        val translator = object :Translator{
+            override suspend fun translateEnToRu(text: String): String =
+                "Его успех вызвал зависть у некоторых его старых друзей."
+        }
         val notes = Skyeng.Companion.Meaning(
             alternatives = listOf(),
             definition = Skyeng.Companion.MeaningDefinition(
@@ -136,7 +141,7 @@ class SkyengTest : StringSpec({
             text = "jealous",
             transcription = "ˈʤɛləs",
             translation = Skyeng.Companion.Translation(text = "завистливый")
-        ).toAnkiClozeNote("test").filterNotNull()
+        ).toAnkiClozeNote("test", translator = translator).filterNotNull()
         notes.size shouldBe 2
         val first = notes.first()
         first.fields.text shouldBe """