Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tap-and-hold support to TrackList #75

Closed
sgraca opened this issue Mar 2, 2017 · 5 comments
Closed

Add tap-and-hold support to TrackList #75

sgraca opened this issue Mar 2, 2017 · 5 comments

Comments

@sgraca
Copy link
Contributor

sgraca commented Mar 2, 2017

Hi,

After upgrading to 2.13.0 (and later 2.13.1) I noticed that it's no longer possible to remove multiple items from the queue on mobile. If I select multiple items then, the menu which is displayed on the bottom of the screen does not have remove option. Available options are: play, next, queue, playlist and start radio.
If I hold an item a little bit longer a context popup appears with remove option, but then it acts weird. Although single item is selected it removes multiple items. And it appears random. Sometimes clicking one item on queue which has 10 items leaves only two or three items in the queue.
I managed to reproduce such behaviour in a desktop browser. This happens when for some reason when I right click a song in the queue it is not highlighted but the menu appears. Clicking remove then has this strange effect.

Thanks,
Sebastian

@jaedb
Copy link
Owner

jaedb commented Mar 6, 2017

I have been unable to replicate this issue. Is anyone else experiencing this?

@sgraca have you tried using test mode to gain further insight into the issue?

@sgraca
Copy link
Contributor Author

sgraca commented Mar 6, 2017

Strange, currently I can see context menu toggle (three dots) when selecting items in the queue. Previously I saw standard blue bar at the bottom of the screen. Maybe the browser was still using cached version.
However I'm still able to reproduce removal of multiple items (but as it's possible to remove items from the queue, it's not a big deal). If you're still interested I attached debug log for this action.
How to reproduce:

  • in the developer tools change to mobile device
  • add some tracks to queue
  • go to queue and press and hold a track until context menu appears
  • click remove
    raspberry-1488832388072.txt

@jaedb
Copy link
Owner

jaedb commented Mar 7, 2017

@sgraca Thanks for that extra info. Are you experiencing this issue on a true touch device?

There is no accurate way to emulate another device or browser and it's behavior, especially regarding touch behavior. For accurate testing use a dedicated testing service like BrowserStack where actual devices are used.

@sgraca
Copy link
Contributor Author

sgraca commented Mar 7, 2017

@jaedb Yes, that's what happens on my mobile phone. It's easily reproducible in Chrome Dev tools after switching to a mobile device profile. Just like described (touch and hold a song in the middle of the queue).

@jaedb jaedb added the bug label Mar 8, 2017
@jaedb
Copy link
Owner

jaedb commented Mar 8, 2017

I think I've got my head around the issue here. Ultimately it's constrained to tap and hold behavior on track items, so I've updated the issue title to reflect this.

At this stage tap and hold is not strictly supported, so further consideration is required on how we can accommodate this.

In the meantime, the context menu trigger (blue circle button) covers this functionality.

@jaedb jaedb changed the title Removing from queue broken Add tap-and-hold support to TrackList Mar 8, 2017
@jaedb jaedb added 2.13 (current) and removed bug labels Mar 8, 2017
@jaedb jaedb closed this as completed in 7e67926 Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants