Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom local artist library URI ignored when force-refreshing artist library #810

Closed
sulph68 opened this issue Feb 16, 2022 · 7 comments
Closed
Labels
bug confirmed A bug that has successfully been replicated and can be resolved

Comments

@sulph68
Copy link

sulph68 commented Feb 16, 2022

Hi

I am trying to get the Artist library to pickup from the ID3 tag of artist using the Advanced URI.
The URI i am using is
local:directory?type=artist

however, it doesn't seem to pick up correctly and continues to only refresh based on albumartist tag.
Is there something special that needs to be done? how would i debug this?

Thanks lots

@sulph68
Copy link
Author

sulph68 commented Feb 16, 2022

After some digging, i found and fixed the bug some what. it seems that the "refresh" icons does not pick up the advanced URI settings defined. As i only needed the artists to be found, i removed a few of the role=albumartist uris. This allowed it to pick up the artist names as is. This is a rough patch however. a more complete fix is to have the refresh button pick up the advanced URI settings as defined within the settings panel.

@jaedb jaedb changed the title Advanced URI -> Artist doesn't seem to pick up artiest library Custom local artist library URI ignored when force-refreshing artist library Mar 9, 2022
@jaedb jaedb added the bug label Mar 9, 2022
@jaedb
Copy link
Owner

jaedb commented Mar 9, 2022

@sulph68 Please make sure any of your future tickets use the provided issue templates.

@0n3man
Copy link

0n3man commented Mar 17, 2022

sulph68 can you provide details on what you did as a work around as I have this same issue and I'm trying to get the artist to show in the interface. Thanks

@sulph68
Copy link
Author

sulph68 commented Mar 17, 2022

hi @On3man,

It seems that Iris uses the ID3 tag "album artist", as the filter for the artist. it just wasn't possible for me to go change all my tags. So YMMV.

What i did was that i made edits in the app.js file as well as the app.min.js. the former really just to test but the latter is the one that is usually loaded.

In both cases, the general steps are to look for

  1. the library_artists_uri and change that to local:directory?type=artist (line 180471)
  2. look for the artists filter and change that to only type=artist (line 177855)

in the app.min.js case, it was more tricky to edit but it works.
Once this is done, clear all the caches for the page and do a reload. You should then see all your artists listed as you prefer.

Hope that works for you too!

@0n3man
Copy link

0n3man commented Mar 17, 2022

thanks

@0n3man
Copy link

0n3man commented Mar 18, 2022

FYI - I only needed to change item 1 in both of the files mentioned.

@sulph68
Copy link
Author

sulph68 commented Mar 19, 2022

sounds great! hope a fix will get rolled in officially soon though! ;-)

@jaedb jaedb added the confirmed A bug that has successfully been replicated and can be resolved label May 1, 2022
@jaedb jaedb closed this as completed in 8bf47b8 May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed A bug that has successfully been replicated and can be resolved
Projects
None yet
Development

No branches or pull requests

3 participants