Merge "ReceiveCommits: Don't synchronize on non-final fields"

Author: dpursehouse

gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java

@@ -1755,9 +1755,7 @@ public Void call()
               insertChange(threadLocalDb);
             }
           }
-          synchronized (newProgress) {
-            newProgress.update(1);
-          }
+          synchronizedIncrement(newProgress);
           return null;
         }
       }));
@@ -2174,9 +2172,7 @@ public PatchSet.Id call() throws OrmException, IOException,
               }
             }
           } finally {
-            synchronized (replaceProgress) {
-              replaceProgress.update(1);
-            }
+            synchronizedIncrement(replaceProgress);
           }
         }
       }));
@@ -2846,4 +2842,10 @@ private static boolean isHead(final ReceiveCommand cmd) {
   private static boolean isConfig(final ReceiveCommand cmd) {
     return cmd.getRefName().equals(RefNames.REFS_CONFIG);
   }
+
+  private static void synchronizedIncrement(Task p) {
+    synchronized (p) {
+      p.update(1);
+    }
+  }
 }