Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single persistent Experiment object for the whole GUI #2

Open
vnegnev opened this issue Nov 18, 2021 · 0 comments
Open

Use a single persistent Experiment object for the whole GUI #2

vnegnev opened this issue Nov 18, 2021 · 0 comments

Comments

@vnegnev
Copy link

vnegnev commented Nov 18, 2021

Right now, each class defined in the seq folder creates its own Experiment object internally, and uses this to send over data. This isn't good because
a) it has processing and communication overhead, and
b) the Experiment class has some internal state (such as whether the gradient DACs have been initialised or not) which can't be used if you're making new objects each time.
I'd recommend refactoring the code to have a central Experiment object, and each seq class would just call its add_flodict() and run() methods. You then wouldn't need to keep calling __del__() each time it runs either - this also slows things down a little bit.

I can advise further if there are any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant