Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the app size #5

Open
lucasbento opened this issue Aug 20, 2018 · 7 comments
Open

Decrease the app size #5

lucasbento opened this issue Aug 20, 2018 · 7 comments
Labels
Milestone

Comments

@lucasbento
Copy link

First of all, thank you for open-sourcing this, it's a really cool app!

I think there should be a small research on why the app size is 279.7 MB, I believe it's possible to decrease that drastically as it's just a menubar app, I noticed that it's using packages like lodash which is pretty big but as it's using parcel (which I don't have much experience on) I'm not sure if it's doing properly tree-shaking or not.

@joshghent
Copy link
Owner

Yeah agreed, that is way too large. I'd more than welcome a PR if you are able to! Alternatively, I'll check into where I can cut the app size as soon as I can

@joshghent joshghent added this to the v2.0.0 milestone Aug 24, 2018
@joshghent joshghent added hacktoberfest Issues that can be sorted for Digital Oceans Hacktoberfest! and removed hacktoberfest Issues that can be sorted for Digital Oceans Hacktoberfest! labels Oct 1, 2018
@joshghent joshghent removed hacktoberfest Issues that can be sorted for Digital Oceans Hacktoberfest! labels May 14, 2019
@joshghent joshghent added the hacktoberfest Issues that can be sorted for Digital Oceans Hacktoberfest! label Oct 22, 2019
@dhuang612
Copy link
Contributor

Hi,

I can take a look at this

@joshghent
Copy link
Owner

All yours @dhuang612 - be great to have another contribution! 👍

@dhuang612
Copy link
Contributor

created PR #112

@jamescallumyoung
Copy link
Collaborator

I wasn't involved in this when #112 was closed so I'll defer to you @joshghent ; can we consider this closed now?

@jamescallumyoung jamescallumyoung added stale and removed hacktoberfest Issues that can be sorted for Digital Oceans Hacktoberfest! help wanted labels Sep 24, 2020
@joshghent
Copy link
Owner

@jamescallumyoung Well let's check the app size now and see if it's acceptable. Maybe this can push forward the Github Actions CI work so we can measure the app size?

@jamescallumyoung
Copy link
Collaborator

Sounds good. Lets leave it for now then and see what the current size is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants