Skip to content

Strict mode - Warn for aliases that match a dependency name #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bebraw opened this issue May 6, 2016 · 3 comments
Closed

Strict mode - Warn for aliases that match a dependency name #79

bebraw opened this issue May 6, 2016 · 3 comments
Assignees
@jonathanglasmeyer
Labels
enhancement

Comments

@bebraw
Copy link
Contributor

bebraw commented May 6, 2016

This should check for resolve.root at least. The point is that we want to avoid a case where webpack picks up something from the project root over node_modules.

Related: reduxjs/redux#1681 .
@jonathanglasmeyer
Copy link
Collaborator

Implementation approach: the _.intersection of the a) array of folder names in node_modules with the b) flattened array of subfolders under all resolve.root folders should be empty.

@jonathanglasmeyer
Copy link
Collaborator

I am on this, using joi 9 .extend and it's awesome. :) will probably pr tomorrow.

@jonathanglasmeyer jonathanglasmeyer self-assigned this May 6, 2016
@jonathanglasmeyer jonathanglasmeyer mentioned this issue May 7, 2016
Merged
@jonathanglasmeyer
Copy link
Collaborator

A baseline version of this is implemented in #81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanglasmeyer jonathanglasmeyer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bebraw @jonathanglasmeyer