Review feedback

Author: maurei

src/JsonApiDotNetCore.OpenApi/SwaggerComponents/JsonApiObjectNullabilityProcessor.cs

@@ -7,8 +7,7 @@ namespace JsonApiDotNetCore.OpenApi.SwaggerComponents
     /// </summary>
     /// <remarks>
     /// Initially these entries are marked nullable by Swashbuckle because nullable reference types are not enabled. This post-processing step can be removed
-    /// entirely once we enable nullable reference types. See eg
-    /// https://github.com/degreed/JsonApiCorePrototype/blob/936db8950d925f1b8a055cf5d8bba753f6579094/src/Web/OpenApi/JsonApiObjects/Documents/ManyResourceIdentifierResponseDocument.cs#L7
+    /// entirely once we enable nullable reference types.
     /// </remarks>
     internal sealed class JsonApiObjectNullabilityProcessor
     {

test/OpenApiClientTests/LegacyClient/ClientAttributeRegistrationLifeTimeTests.cs

@@ -5,8 +5,6 @@
 using TestBuildingBlocks;
 using Xunit;
 
-#pragma warning disable AV1704 // Don't include numbers in variables, parameters and type members
-
 namespace OpenApiClientTests.LegacyClient
 {
     public sealed class ClientAttributeRegistrationLifetimeTests
@@ -135,7 +133,7 @@ public async Task Request_is_unaffected_by_attribute_registration_for_different_
                 airplane => airplane.AirtimeInHours))
             {
                 using (openApiClient.RegisterAttributesForRequestDocument<AirplanePatchRequestDocument, AirplaneAttributesInPatchRequest>(requestDocument2,
-                    airplane => airplane.IsInMaintenance))
+                    airplane => airplane.SerialNumber))
                 {
                 }
 
@@ -149,7 +147,7 @@ public async Task Request_is_unaffected_by_attribute_registration_for_different_
     ""type"": ""airplanes"",
     ""id"": """ + airplaneId2 + @""",
     ""attributes"": {
-      ""is-in-maintenance"": false
+      ""serial-number"": null
     }
   }
 }");

test/OpenApiClientTests/LegacyClient/ResponseTests.cs

@@ -9,8 +9,6 @@
 using OpenApiClientTests.LegacyClient.GeneratedCode;
 using Xunit;
 
-#pragma warning disable AV1704 // Don't include numbers in variables, parameters and type members
-
 namespace OpenApiClientTests.LegacyClient
 {
     public sealed class ResponseTests
@@ -22,13 +20,13 @@ public async Task Getting_resource_collection_translates_response()
         {
             // Arrange
             const string flightId = "ZvuH1";
-            const string flightDestination = "Destination of Flight";
-            const string fightServiceOnBoard = "Movies";
+            const string flightDestination = "Amsterdam";
+            const string flightServiceOnBoard = "Movies";
             const string flightDepartsAt = "2014-11-25T00:00:00";
             const string documentMetaValue = "1";
-            const string flightMetaValue = "https://api.jsonapi.net/docs/#get-flights";
+            const string flightMetaValue = "https://jsonapi.net/api/docs/#get-flights";
             const string purserMetaValue = "https://jsonapi.net/api/docs/#get-flight-purser";
-            const string cabinPersonnelMetaValue = "https://jsonapi.net/api/docs/#get-flight-cabin-crew-members";
+            const string cabinCrewMembersMetaValue = "https://jsonapi.net/api/docs/#get-flight-cabin-crew-members";
             const string passengersMetaValue = "https://jsonapi.net/api/docs/#get-flight-passengers";
             const string topLevelLink = HostPrefix + "flights";
             const string flightResourceLink = topLevelLink + "/" + flightId;
@@ -53,7 +51,7 @@ public async Task Getting_resource_collection_translates_response()
         ""departs-at"": """ + flightDepartsAt + @""",
         ""arrives-at"": null,
         ""services-on-board"": [
-          """ + fightServiceOnBoard + @""",
+          """ + flightServiceOnBoard + @""",
           """",
           null
         ]
@@ -74,7 +72,7 @@ public async Task Getting_resource_collection_translates_response()
             ""related"": """ + flightResourceLink + @"/cabin-crew-members""
           },
           ""meta"": {
-             ""docs"": """ + cabinPersonnelMetaValue + @"""
+             ""docs"": """ + cabinCrewMembersMetaValue + @"""
           }
         },
         ""passengers"": {
@@ -120,13 +118,14 @@ public async Task Getting_resource_collection_translates_response()
             flight.Meta["docs"].Should().Be(flightMetaValue);
 
             flight.Attributes.FinalDestination.Should().Be(flightDestination);
+            flight.Attributes.StopOverDestination.Should().Be(null);
             flight.Attributes.ServicesOnBoard.Should().HaveCount(3);
-            flight.Attributes.ServicesOnBoard.ElementAt(0).Should().Be(fightServiceOnBoard);
+            flight.Attributes.ServicesOnBoard.ElementAt(0).Should().Be(flightServiceOnBoard);
             flight.Attributes.ServicesOnBoard.ElementAt(1).Should().Be(string.Empty);
             flight.Attributes.ServicesOnBoard.ElementAt(2).Should().BeNull();
             flight.Attributes.OperatedBy.Should().Be(Airline.DeltaAirLines);
             flight.Attributes.DepartsAt.Should().Be(DateTimeOffset.Parse(flightDepartsAt, new CultureInfo("en-GB")));
-            flight.Attributes.ArrivesAt.Should().Be(null);
+            flight.Attributes.ArrivesAt.Should().BeNull();
 
             flight.Relationships.Purser.Data.Should().BeNull();
             flight.Relationships.Purser.Links.Self.Should().Be(flightResourceLink + "/relationships/purser");
@@ -138,7 +137,7 @@ public async Task Getting_resource_collection_translates_response()
             flight.Relationships.CabinCrewMembers.Links.Self.Should().Be(flightResourceLink + "/relationships/cabin-crew-members");
             flight.Relationships.CabinCrewMembers.Links.Related.Should().Be(flightResourceLink + "/cabin-crew-members");
             flight.Relationships.CabinCrewMembers.Meta.Should().HaveCount(1);
-            flight.Relationships.CabinCrewMembers.Meta["docs"].Should().Be(cabinPersonnelMetaValue);
+            flight.Relationships.CabinCrewMembers.Meta["docs"].Should().Be(cabinCrewMembersMetaValue);
 
             flight.Relationships.Passengers.Data.Should().BeNull();
             flight.Relationships.Passengers.Links.Self.Should().Be(flightResourceLink + "/relationships/passengers");
@@ -187,6 +186,8 @@ public async Task Getting_resource_translates_response()
             document.Data.Attributes.ArrivesAt.Should().Be(DateTimeOffset.Parse(arrivesAtWithUtcOffset));
             document.Data.Attributes.ServicesOnBoard.Should().BeNull();
             document.Data.Attributes.FinalDestination.Should().BeNull();
+            document.Data.Attributes.StopOverDestination.Should().BeNull();
+
             document.Data.Attributes.OperatedBy.Should().Be(default(Airline));
         }