Skip to content

update the test suite for draft-next #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hauner opened this issue Mar 26, 2024 · 6 comments
Closed

update the test suite for draft-next #725

hauner opened this issue Mar 26, 2024 · 6 comments

Comments

@hauner
Copy link
Contributor

hauner commented Mar 26, 2024

not all tests align with the draft-next schemas

@gregsdennis
Copy link
Member

Can you provide details of misaligned tests that you've found, please? Just saying "it's wrong" isn't particularly helpful.

@hauner
Copy link
Contributor Author

hauner commented Mar 28, 2024

draft-next/id.json

  • "Valid use of empty fragments in location-independent $id"/"Identifier name with absolute URI" is not valid anymore because the ˋ$idˋ pattern changed in core.json

that is the only one I checked 😉 I stopped after you mentioned that the tests are not up to date...

I can check my other failing tests if it helps.

@notEthan
Copy link
Contributor

That test is dropped by #718 (merged just now).
Any other problems?

@hauner
Copy link
Contributor Author

hauner commented Apr 1, 2024

I'm down to two test failures (unevaluatedProperties/propertyDependencies) implementing draft-next, so I think there is no "wrong" test anymore.

I wonder if there are missing tests though. draft-next talks about

"contains", "minContains", and "maxContains" now apply to objects as well as arrays"

and I expected some failing tests for the object case but there are none.

contains.json has a few changes but I don't see any tests explicitly on objects.

@gregsdennis
Copy link
Member

contains applied to objects for a short time, but we decided not to do that.

Honestly, I wouldn't worry about getting draft-next right now. It's not published, and there's clearly work to be done. We're going to have to go through it carefully before publication.

@Julian
Copy link
Member

Julian commented Apr 6, 2024

Sounds like we should close this then. If you have specific issues nonetheless (of tests which don't match the spec text), open those please.

@Julian Julian closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants