-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Migrate rule from TSLint: react-iframe-missing-sandbox #2754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What is the purpose of this rule? A PR is premature before it's clear this is a rule we want. |
We use this rule internally to remind engineers to follow security best practices and use "sandbox" attribute on iframes to enable only the functionality that is required. PR is here to show what the rule actually does. I'll certainly leave it for your consideration. More reading on the iframe sandbox, if needed: |
@ljharb , any news regarding the proposal? Thank you. |
@tosmolka i think this is fine - let's go with |
We would like to port
react-iframe-missing-sandbox
from tslint-microsoft-contrib into ESLint and this plugin seems like a good place to put it.See initial PR:
#2753
Any feedback will be appreciated!
The text was updated successfully, but these errors were encountered: