Skip to content

Update button should give feedback on click and should be friendly for users with eyesight issues #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krassowski opened this issue Apr 28, 2021 · 1 comment
Labels
enhancement Good first issue Good first issue to be tackled by new contributors

Comments

@krassowski
Copy link
Member

krassowski commented Apr 28, 2021

Is your feature request related to a problem? Please describe.

Diffing moderate-size notebooks takes time even at a very high-spec machine; diffing large notebooks will always take some time; the refresh button is very useful but it does not provide any feedback on clicking it. Below is an example of me trying to update a diff on my day job by clicking it once... and then again and then several times again because I am not sure if it got pressed (2 minutes GIF, feel free to skip):

update-button

  1. There is no :active pseaudoclass so I cannot see if my click worked (there is only :hover)
  2. The button stays the same after clicking and there is no visual indication of the diff reloading
  3. After the diff starts re-loading after the first click the button persist. It only disappears after some time with what appears to be n-th reloading; strangely the reloadings of diffs continue afterwards

And not directly related but still something which annoys my colorblindness:

  1. The contrast of the button is poor in the first place

Describe the solution you'd like

  1. Add :active css pseudoclass
  2. Hide button after it gets clicked or grey it out and/or show visual loading indicator
  3. If the button remains available, handle the repeated click better

For visual colors:
4. Make it darker orange and/or make the text and border bolder and/or add dark font shadow

Additional context

  • Python package version: 0.30
  • Extension version: v0.30
@krassowski
Copy link
Member Author

Relevant styles:

button.jp-git-diff-refresh {
border: solid 1px var(--jp-warn-color2);
}
button.jp-git-diff-refresh .jp-ToolbarButtonComponent-label {
color: var(--jp-warn-color1);
}

@fcollonval fcollonval added the Good first issue Good first issue to be tackled by new contributors label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Good first issue Good first issue to be tackled by new contributors
Projects
None yet
Development

No branches or pull requests

2 participants