gptel-rewrite on region discards last newline

[ekenberg]

Please update gptel first -- errors are often fixed by the time they're reported.

• I have updated gptel to the latest commit and tested that the issue still exists

Bug Description

gptel-rewrite on a region discards last newline

Backend

None

Steps to Reproduce

With this code:

# line before region
for i in range(1, 10 + 1):
    print(i)
# line after region

mark (region) the two lines between the comments, including end-of-line on second line
run gptel-rewrite and tell it to simplify the code
accept the rewrite and the result will look something like this (the last comment is moved to previous line because missing newline in gptel-rewrite result)

# line before region
for i in range(1, 11):
    print(i)# line after region

Additional Context

Emacs version: "GNU Emacs 29.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2024-05-03"
gptel version: 20250107.34

Backtrace

No response

Log Information

No response

[karthink]

I can't reproduce this. Which backend/model did you use here?

[ekenberg]

I can't reproduce this. Which backend/model did you use here?

Thank you for responding.

I am using Claude 3.5 Sonnet 2024-10-22. But weirdly enough, I cannot reproduce it either, despite going back and forth between gptel-versions and other potential changes since reporting. I did spend quite a bit of time testing before reporting, so the issue was definitely there. But now it's gone.

I am closing this now. If the issue resurfaces, I shall try to provide more details on the data sent to and from the backend.

Thanks a lot for your fine work on gptel!