Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(developer): kmc-keyboard-info should not list web support for multi-keyboard packages #11645

Open
mcdurdin opened this issue Jun 1, 2024 · 1 comment
Assignees
Milestone

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Jun 1, 2024

I wonder also about the bundle packages (e.g. galaxie_greek_hebrew_mnemonic) if there may be a separate issue to tackle here? It seems like we are adding support for web platforms but the bundled name will not be available in web.

This probably needs to be tackled on the compiler side. A little more nuance may be needed to exclude web platforms from multi-keyboard packages.

Originally posted by @mcdurdin in keymanapp/keyboards#2793 (comment)

See also keymanapp/keyboards#2423

@mcdurdin
Copy link
Member Author

mcdurdin commented Jun 7, 2024

https://downloads.keyman.com/keyboards/galaxie_greek_hebrew_positional/2.2.1/ is clearly wrong: .js filename does not match folder name:

image

This is coming up because there are .js files inside the package, and each .js supports web, but collectively they don't work.

@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@mcdurdin mcdurdin modified the milestones: A18S5, A18S7 Jul 5, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@mcdurdin mcdurdin modified the milestones: A18S8, A18S20 Aug 6, 2024
@mcdurdin mcdurdin modified the milestones: A18S20, 19.0 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants