Skip to content

fix(#151): fix gitlab post comments url #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Apr 14, 2025

Thank you for submitting this pull request

fixes #151

Description

  • Fixed the url used to post comments on Gitlab

How Has This Been Tested?

Tested directly on Gitlab using a dummy repo example https://gitlab.com/lampajr/backporting-example/-/merge_requests/1#note_2450321842

Checklist

  • Tests added if applicable.
  • Documentation updated if applicable.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Note: dist/cli/index.js and dist/gha/index.js are automatically generated by git hooks and gh workflows.

First time here?

This project follows git conventional commits pattern, therefore the commits should have the following format:

<type>(<optional scope>): <subject>
empty separator line
<optional body>
empty separator line
<optional footer>

Where the type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

NOTE: if you are still in a work in progress branch and you want to push your changes remotely, consider adding --no-verify for both commit and push, e.g., git push origin <feat-branch> --no-verify - this could become useful to push changes where there are still tests failures. Once the pull request is ready, please amend the commit and force-push it to keep following the adopted git commit standard.

How to prepare for a new release?

There is no need to manually update package.json version and CHANGELOG.md information. This process has been automated in Prepare Release Github workflow.

Therefore whenever enough changes are merged into the main branch, one of the maintainers will trigger this workflow that will automatically update version and changelog based on the commits on the git tree.

More details can be found in package release section of the README.

@lampajr lampajr self-assigned this Apr 14, 2025
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
89.2% (+0.04% 🔼)
504/565
🟢 Branches 85.33% 192/225
🟢 Functions 87.5% 112/128
🟢 Lines
89.05% (+0.04% 🔼)
488/548

Test suite run success

217 tests passing in 18 suites.

Report generated by 🧪jest coverage report action from 69b693b

@lampajr lampajr marked this pull request as ready for review April 14, 2025 15:45
@lampajr lampajr merged commit d74a787 into kiegroup:main Apr 14, 2025
3 checks passed
@lampajr lampajr deleted the fix_151 branch April 14, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLab, Enabling enableErrorNotification postes comment to issue instead of merge request
1 participant