Skip to content

Commit f83c0ee

Browse files
authored
fix s2i on cluster RT tests (#2015)
* chore: use smaller s2i nodejs builder Signed-off-by: Matej Vasek <mvasek@redhat.com> * test: skip python s2i on cluster build test on GH Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: do check at correct place Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
1 parent 7b09bcd commit f83c0ee

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pkg/builders/s2i/builder.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import (
3636
// DefaultName when no WithName option is provided to NewBuilder
3737
const DefaultName = builders.S2I
3838

39-
var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16"
39+
var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16-minimal"
4040
var DefaultQuarkusBuilder = "registry.access.redhat.com/ubi8/openjdk-17"
4141
var DefaultPythonBuilder = "registry.access.redhat.com/ubi8/python-39"
4242

test/oncluster/scenario_runtime_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ func TestRuntime(t *testing.T) {
4545
for _, builder := range runtimeSupportMap[lang] {
4646
if targetBuilder == "" || builder == targetBuilder {
4747
t.Run(fmt.Sprintf("%v_%v_test", lang, builder), func(t *testing.T) {
48+
if lang == "python" && os.Getenv("GITHUB_ACTIONS") == "true" {
49+
t.Skip("skipping python test in GH action because of space requirement")
50+
}
4851
runtimeImpl(t, lang, builder)
4952
})
5053
}

0 commit comments

Comments
 (0)