Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New empty tab addition feature development #21

Open
kshashikumar opened this issue Oct 28, 2024 · 4 comments
Open

New empty tab addition feature development #21

kshashikumar opened this issue Oct 28, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@kshashikumar
Copy link
Owner

  • New empty tab addition feature development
@kshashikumar kshashikumar added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 28, 2024
@kshashikumar kshashikumar added this to the v2.0.0 milestone Oct 28, 2024
@r9young
Copy link

r9young commented Dec 16, 2024

Hi @kshashikumar,

I’ve drafted the UI and would like to confirm if this aligns with what you’re looking for.

Image 16-12-2024 at 3 31 pm

I’d also appreciate it if you could assign this issue to me.

Cheers
r9young

@kshashikumar
Copy link
Owner Author

kshashikumar commented Dec 16, 2024

Hi @r9young ,

This issue requires an assessment before proceeding. Currently, when users click on the query icon for table names, the backend takes the dbName as a parameter and executes a query based on the selected database.

For cases where a new empty tab is created, we need to handle this scenario on the backend. Please review this approach, and let’s make the discussion productive by exploring more implementation options.

Looking forward to your thoughts. Also, don’t forget to leave a ⭐ if you like the project! and join Slack

Thanks & Regards,
Shashi

@r9young
Copy link

r9young commented Dec 22, 2024

Hi @kshashikumar,

Updated the application as follows:

  1. Add New Tab Buttons:

    • Enhance the addTab and handleExecQueryClick functions to include functionality for adding New Tab buttons.
    • Introduce a new function named updateTableName.

    Reference Image

  2. Update the resultgrid Component:

    • Add error handling to check if dbName or schemaName is empty.
    • Modify the ngOnChanges lifecycle method in the resultgrid.component.

    Reference Image

If you have any questions or need further clarification about the updates or functionality, feel free to ask! Additionally, if you'd like suggestions for optimizing the implementation or testing the changes, let me know, and I'd be happy to help. 😊

@r9young
Copy link

r9young commented Jan 21, 2025

Hi @kshashikumar,

I’ve shared the same message on the pull request, but just in case you haven’t seen it, I’ve included my updates below:

Based on your feedback, I’ve made the following updates:

  • Navbar Button Styling: Aligned to match the rest of the design.

  • Unnecessary Button Below: Removed.
    UpdatedNew

  • AI Prompt Issue: Resolved, and it is now functioning as expected.
    AIPrompt

Before submitting another pull request, I’d like to you to review the effects of these updates. If you have any additional thoughts or suggestions regarding my changes, please feel free to share them.

Best regards,
r9young

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants