Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token refresh #180

Merged
merged 23 commits into from
Nov 9, 2018
Merged

Token refresh #180

merged 23 commits into from
Nov 9, 2018

Conversation

y-kkamil
Copy link

@y-kkamil y-kkamil commented Oct 30, 2018 •
edited
Loading

Description

Changes proposed in this pull request:

Add possibility to silently refresh token using OpenID Connect prompt=none param.

  • For now, if authorisation is set to something different than OpenID Connect and/or silent token refresh is disabled, user will be redirected to the logout page without any warning - not good if he has some unsaved work. There is a follow-up for that - Warning before token expiry #179

Related issue(s)
See also #179
Resolves #124

@y-kkamil y-kkamil added enhancement New feature or request area/luigi labels Oct 30, 2018
@dariadomagala-sap dariadomagala-sap self-assigned this Oct 30, 2018
dariadomagala-sap
dariadomagala-sap suggested changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@dariadomagala-sap dariadomagala-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App is not able to get the oidc.min.js file at the beginning. When token expires, it reloads the page and redirects to http://luigi.com:4200/?reason=tokenExpired&error=Frame%20window%20timed%20out#/overview but doesn't change the token.

@bszwarc bszwarc self-assigned this Nov 5, 2018
bszwarc
bszwarc suggested changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of comments and one restructuring suggestion :)

bszwarc
bszwarc suggested changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

bszwarc
bszwarc approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@y-kkamil y-kkamil merged commit 13ff146 into SAP:master Nov 9, 2018
@y-kkamil y-kkamil deleted the token-refresh branch November 9, 2018 13:28
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Token refresh (SAP#180)
269ee92 
* add support for openid connect token refresh

* refresh token

* third party cookies support

* token renewal

* remove test values

* remove debugger statement

* add docu

* remove debugger statement

* changes in documenation

* change webpack config and oidc lib location

* add default logout url

* change bug in library-loaders

* change docu after review

* correct documentation after review

* documentation changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bszwarc bszwarc bszwarc approved these changes

@dariadomagala-sap dariadomagala-sap dariadomagala-sap approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@kazydek kazydek Awaiting requested review from kazydek

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

@pekura pekura Awaiting requested review from pekura

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oauth token expiration handling
4 participants
@y-kkamil @bszwarc @dariadomagala-sap @kwiatekus