Skip to content

feat: Inline context for custom and migration op events #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Mar 5, 2025

No description provided.

@keelerm84 keelerm84 requested a review from a team as a code owner March 5, 2025 21:08
@keelerm84 keelerm84 changed the title mk/sdk 1100/inline custom feat: Inline context for custom and migration op events Mar 5, 2025
Copy link
Contributor

@louis-launchdarkly louis-launchdarkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is what we discussed. Maybe there is some missing Migration tracker spec change needed to make the CI test green?

@keelerm84 keelerm84 force-pushed the mk/sdk-1100/inline-custom branch from 3b1e70a to 91a2746 Compare March 12, 2025 13:47
@keelerm84
Copy link
Member Author

@louis-launchdarkly re-requesting your review. After further discussion with Matt Wagner, we decided to back out the simplification of index events for now.

The change is what we discussed. Maybe there is some missing Migration tracker spec change needed to make the CI test green?

This is because the SDK test harness hasn't been updated yet, which is going to cause a failure until that is published. I won't merge until everything is released and passing.

@keelerm84 keelerm84 merged commit ab5b14f into main Mar 13, 2025
7 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1100/inline-custom branch March 13, 2025 19:56
keelerm84 pushed a commit that referenced this pull request Mar 13, 2025
🤖 I have created a release *beep* *boop*
---


##
[8.9.0](8.8.4...8.9.0)
(2025-03-13)


### Features

* Inline context for custom and migration op events
([#315](#315))
([ab5b14f](ab5b14f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants