Fix typo and add important include #173
Conversation
…n not having the correct include order
toluschr
changed the title
include/LCUI/LCUI.h
Outdated
| @@ -32,6 +32,7 @@ | |||
| #ifndef LCUI_H | |||
| #define LCUI_H | |||
|
|
|||
| #include <LCUI_Build.h> | |||
There was a problem hiding this comment.
Add "#include <LCUI_Build.h>" to "include/LCUI.h" to avoid issues when include order is wrong
LCUI_Build.h should always be the first one to be included, I think LCUI.h does not need to be modified.
I have the following improvements, how do you feel?
files:
+ include/LCUI.hinclude/LCUI.h：
#include <LCUI_Build.h>
#include <LCUI/LCUI.h>After this modification, we can include the header file in a new way:
- #include <LCUI_Build.h>
- #include <LCUI/LCUI.h>
+#include <LCUI.h>There was a problem hiding this comment.
That seems like a good idea. Similar to how windows handles all important includes with Windows.h
There was a problem hiding this comment.
@toluschr Ok, since you and I agree with these improvements, please replace your current changes with the above.
|
I also made two .spec files (runtime and devel) to easily install this on fedora and other linux distros with an rpm package. Perhaps you could add the rpm files as a relese. https://gist.github.com/toluschr/c3239049ed88334fd83ab96450c61a42 (You can build the spec files to an rpm file with the following commands) |
include/LCUI.h
Outdated
| @@ -0,0 +1,2 @@ | |||
| #include <LCUI_Build.h> | |||
| #include <LCUI/LCUI.h> | |||
|
License is MIT, not GPL. https://gist.github.com/toluschr/c3239049ed88334fd83ab96450c61a42#file-lcui-devel-spec-L6-L7 |
|
I changed the license to MIT! |
* Fix typo in the "building" section * include LCUI_Build.h in LCUI/LCUI.h to avoid lots of errors I had when not having the correct include order * changed: include headers to integrate the changes by lc-soft * added: newline at end of "include/LCUI.h"
Fixes a typo (hellowrold).
Changes proposed in this pull request:
@lc-soft