Skip to content

Update embed_content_request.json schema #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akolson opened this issue Apr 9, 2024 · 0 comments · Fixed by #123
Closed

Update embed_content_request.json schema #122

akolson opened this issue Apr 9, 2024 · 0 comments · Fixed by #123
Assignees
Labels
enhancement P0 - critical Priority: Release blocker or regression

Comments

@akolson
Copy link
Member

akolson commented Apr 9, 2024

Overview

This task involves updating the embed_content_request.json schema to accept a list of files.

Description and outcomes

  • Modify the embed_content_request.json schema to accept a list of files.
    • Name the property files of type array
    • Each file in files is of type object
    • file contains the following fields;
      • url of type string. The url should be a valid URL/URI and open to specific domains.
        • The GCP buckets domain
        • Localhost domains
      • preset of type enum. See format_presets.py for accepted list of options
      • language of type string. Use the language for this.
    • files should be added to the resource property
    • It is an optional property
  • Add additional tests to verify correctness of implementation

Acceptance Criteria

  • A new property files is added to the embed_content_request.json schema
  • Appropriate tests are added to verify correctness

Assumptions and Dependencies

Scope

The scope of this task is limited to;

  • Adding the files property to the embed_content_request.json schema.

Accessibility Requirements

NA

Resources

@akolson akolson added enhancement P0 - critical Priority: Release blocker or regression labels Apr 9, 2024
@akolson akolson added this to the Search Recommendations milestone Apr 9, 2024
@akolson akolson changed the title [WIP - DO NOT ASSIGN]: Update embed_content_request.py schema [WIP - DO NOT ASSIGN]: Update embed_content_request.json schema Apr 9, 2024
@akolson akolson changed the title [WIP - DO NOT ASSIGN]: Update embed_content_request.json schema Update embed_content_request.json schema Apr 9, 2024
@akolson akolson changed the title Update embed_content_request.json schema [WIP - DO NOT ASSIGN]: Update embed_content_request.json schema Apr 9, 2024
@akolson akolson changed the title [WIP - DO NOT ASSIGN]: Update embed_content_request.json schema Update embed_content_request.json schema Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants