Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxmp 4.6.3 #825

Open
AliceLR opened this issue Jan 1, 2025 · 7 comments
Open

libxmp 4.6.3 #825

AliceLR opened this issue Jan 1, 2025 · 7 comments
Milestone

Comments

@AliceLR
Copy link
Contributor

AliceLR commented Jan 1, 2025

Making a new pin for the next bugfix release of libxmp. I don't really have a release date in mind for this aside from "sooner than 18 months from now" 🙂

I added a few more issues to the 4.6.2 milestone. Aside from those, nice-to-haves would be:

@AliceLR AliceLR added this to the 4.6.2 milestone Jan 1, 2025
@AliceLR AliceLR pinned this issue Jan 1, 2025
@sezero
Copy link
Collaborator

sezero commented Feb 8, 2025

We have four small patches in since 4.6.1, one being the bad cve fix to miniz reverted. See PR/830 for the proposed changelog.

@AliceLR: If you don't have any patches scheduled, I suggest that we make a 4.6.2 patch release this month and move the remaining items in 4.6.2 milestone to 4.6.3.

@AliceLR AliceLR changed the title libxmp 4.6.2 libxmp 4.6.3 Feb 11, 2025
@AliceLR AliceLR modified the milestones: 4.6.2, 4.6.3 Feb 11, 2025
@AliceLR
Copy link
Contributor Author

AliceLR commented Feb 11, 2025

I kicked most issues down to 4.6.3 since they're non-urgent. There's one thing I would like to check into first before 4.6.2 is cut: OctaMED effect 1Fxx, since the change in 4.6.1 might have affected some modules to play differently incorrect than before. This is a delay/retrigger so relatively easy to implement in libxmp semantics, I just never got to it.

@sezero
Copy link
Collaborator

sezero commented Feb 11, 2025

OK

@AliceLR
Copy link
Contributor Author

AliceLR commented Feb 19, 2025

Update: still working on this. Not only was I correct about 1Fxx being wrong, but I also got MED command FF3 wrong. Patches for this and MED3 song files should be ready tonight or tomorrow.

edit: and to properly regression test this, I have to fix MED3 and MED4 time factor and tempo... :/

@AliceLR
Copy link
Contributor Author

AliceLR commented Feb 23, 2025

Something came up with libfuzzer, don't tag 4.6.2 just yet.

@sezero
Copy link
Collaborator

sezero commented Feb 23, 2025

Something came up with libfuzzer, don't tag 4.6.2 just yet.

Sure

@sezero
Copy link
Collaborator

sezero commented Feb 24, 2025

OK, 4.6.2 tagged and and released, both at sourceforge and at github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants