Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit test flake]: TestRbfCloseClosingNegotiationLocal fails #9526

Open
guggero opened this issue Feb 18, 2025 · 3 comments
Open

[unit test flake]: TestRbfCloseClosingNegotiationLocal fails #9526

guggero opened this issue Feb 18, 2025 · 3 comments
Labels
bug Unintended code behaviour test flake

Comments

@guggero
Copy link
Collaborator

guggero commented Feb 18, 2025

Occasional failure in unit tests (with cover, run here: https://github.com/lightningnetwork/lnd/actions/runs/13397366371/job/37423165732?pr=9521).

 --- FAIL: TestRbfCloseClosingNegotiationLocal (0.01s)
    --- FAIL: TestRbfCloseClosingNegotiationLocal/send_offer_rbf_iteration_loop (0.01s)
        rbf_coop_test.go:334: no dust field set, expected: no dust
        rbf_coop_test.go:334: no dust field set, expected: no dust
        rbf_coop_test.go:251: unexpected state transition: &{{0xc00027c900 0xc000249440}}
        rbf_coop_test.go:334: no dust field set, expected: no dust
        rbf_coop_test.go:334: no dust field set, expected: no dust
@guggero guggero added bug Unintended code behaviour test flake labels Feb 18, 2025
@Roasbeef
Copy link
Member

Will look into it!

@KapilSareen
Copy link

Hey @guggero do you think this is a case of race-condition because of the t.Parallel()?
What are your opinions on removing it? It causes a slight delay in the total test run time:

$ go test ./lnwallet/chancloser/   # with t.Parallel()
ok      github.com/lightningnetwork/lnd/lnwallet/chancloser     0.290s
$ go test ./lnwallet/chancloser/  # t.Parallel() removed
ok      github.com/lightningnetwork/lnd/lnwallet/chancloser     0.314s

@yyforyongyu
Copy link
Member

@KapilSareen What's its root cause?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended code behaviour test flake
Projects
None yet
Development

No branches or pull requests

4 participants