Skip to content

deque and string might leak memory #59651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
philnik777 opened this issue Dec 22, 2022 · 2 comments
Open

deque and string might leak memory #59651

philnik777 opened this issue Dec 22, 2022 · 2 comments
Assignees
@philnik777
Labels
exception-safety libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@philnik777
Copy link
Contributor

We had a bug in vector which lead to memory leaks. The problem was that a user could throw from inside a constructor, and then the destructor would never be run. This was caused by removing the base class. We also removed base classes from basic_string and deque, so we should add tests for them too and fix memory leaks if we find any.
@philnik777 philnik777 added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. and removed new issue labels Dec 22, 2022
@mlemacio
Copy link

Could you link the vector bug?

@philnik777
Copy link
Contributor Author

#58392

@philnik777 philnik777 mentioned this issue Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philnik777 philnik777

Labels
exception-safety libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlemacio @philnik777