diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp index 04b96a32a8970..b27746f9d6a55 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp +++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp @@ -1770,8 +1770,35 @@ AMDGPUCodeGenPassBuilder::AMDGPUCodeGenPassBuilder( } void AMDGPUCodeGenPassBuilder::addCodeGenPrepare(AddIRPass &addPass) const { + // AMDGPUAnnotateKernelFeaturesPass is missing here, but it will hopefully be + // deleted soon. + + if (EnableLowerKernelArguments) + addPass(AMDGPULowerKernelArgumentsPass(TM)); + + // This lowering has been placed after codegenprepare to take advantage of + // address mode matching (which is why it isn't put with the LDS lowerings). + // It could be placed anywhere before uniformity annotations (an analysis + // that it changes by splitting up fat pointers into their components) + // but has been put before switch lowering and CFG flattening so that those + // passes can run on the more optimized control flow this pass creates in + // many cases. + // + // FIXME: This should ideally be put after the LoadStoreVectorizer. + // However, due to some annoying facts about ResourceUsageAnalysis, + // (especially as exercised in the resource-usage-dead-function test), + // we need all the function passes codegenprepare all the way through + // said resource usage analysis to run on the call graph produced + // before codegenprepare runs (because codegenprepare will knock some + // nodes out of the graph, which leads to function-level passes not + // being run on them, which causes crashes in the resource usage analysis). + addPass(AMDGPULowerBufferFatPointersPass(TM)); + Base::addCodeGenPrepare(addPass); + if (isPassEnabled(EnableLoadStoreVectorizer)) + addPass(LoadStoreVectorizerPass()); + // LowerSwitch pass may introduce unreachable blocks that can cause unexpected // behavior for subsequent passes. Placing it here seems better that these // blocks would get cleaned up by UnreachableBlockElim inserted next in the @@ -1839,3 +1866,12 @@ Error AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const { addPass(SILowerI1CopiesPass()); return Error::success(); } + +bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt &Opt, + CodeGenOptLevel Level) const { + if (Opt.getNumOccurrences()) + return Opt; + if (TM.getOptLevel() < Level) + return false; + return Opt; +} diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h index 576bf40e3328d..9ee406154b9b7 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h +++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h @@ -176,6 +176,12 @@ class AMDGPUCodeGenPassBuilder void addPreISel(AddIRPass &addPass) const; void addAsmPrinter(AddMachinePass &, CreateMCStreamer) const; Error addInstSelector(AddMachinePass &) const; + + /// Check if a pass is enabled given \p Opt option. The option always + /// overrides defaults if explicitly used. Otherwise its default will be used + /// given that a pass shall work at an optimization \p Level minimum. + bool isPassEnabled(const cl::opt &Opt, + CodeGenOptLevel Level = CodeGenOptLevel::Default) const; }; } // end namespace llvm