Skip to content

Commit eafabf6

Browse files
committed
test: fix flaky vinyl/gh test failure
The commit fixes the following test failure: ``` [005] vinyl/gh.test.lua [ fail ] [005] [005] Test failed! Result content mismatch: [005] --- vinyl/gh.result Mon Dec 13 15:03:45 2021 [005] +++ /root/actions-runner/_work/tarantool/tarantool/test/var/rejects/vinyl/gh.reject Fri Dec 17 10:41:24 2021 [005] @@ -716,7 +716,7 @@ [005] ... [005] test_run:wait_cond(function() return finished == 2 end) [005] --- [005] -- true [005] +- false [005] ... [005] s:drop() [005] --- ``` The reason of the failure is that the fiber doing checkpoints fails, because a checkpoint may be already running by the checkpoint daemon. Invoke box.snapshot() under pcall to make the test more robust. Part of #5141
1 parent 74dc1ae commit eafabf6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/vinyl/gh.result

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ end);
695695
...
696696
_ = fiber.create(function()
697697
while cont do
698-
box.snapshot()
698+
pcall(box.snapshot)
699699
fiber.sleep(0.01)
700700
end
701701
finished = finished + 1

test/vinyl/gh.test.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ end);
297297

298298
_ = fiber.create(function()
299299
while cont do
300-
box.snapshot()
300+
pcall(box.snapshot)
301301
fiber.sleep(0.01)
302302
end
303303
finished = finished + 1

0 commit comments

Comments
 (0)