Skip to content

Commit 10ce2aa

Browse files
nanohannohkuepers
and
hkuepers
authored
feat: Add connection_name field to Snowflake config (feast-dev#4600)
Add connection_name field to Snowflake config Signed-off-by: hkuepers <hanno.kuepers@ratepay.com> Co-authored-by: hkuepers <hanno.kuepers@ratepay.com>
1 parent cc41c9e commit 10ce2aa

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

sdk/python/feast/infra/materialization/snowflake_engine.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@ class SnowflakeMaterializationEngineConfig(FeastConfigBaseModel):
4646
""" Type selector"""
4747

4848
config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
49-
""" Snowflake config path -- absolute path required (Cant use ~)"""
49+
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""
50+
51+
connection_name: Optional[str] = None
52+
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """
5053

5154
account: Optional[str] = None
5255
""" Snowflake deployment identifier -- drop .snowflakecomputing.com"""

sdk/python/feast/infra/offline_stores/snowflake.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,10 @@ class SnowflakeOfflineStoreConfig(FeastConfigBaseModel):
8383
""" Offline store type selector """
8484

8585
config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
86-
""" Snowflake config path -- absolute path required (Cant use ~)"""
86+
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""
87+
88+
connection_name: Optional[str] = None
89+
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """
8790

8891
account: Optional[str] = None
8992
""" Snowflake deployment identifier -- drop .snowflakecomputing.com """

sdk/python/feast/infra/online_stores/snowflake.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ class SnowflakeOnlineStoreConfig(FeastConfigBaseModel):
3030
""" Online store type selector """
3131

3232
config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
33-
""" Snowflake config path -- absolute path required (Can't use ~)"""
33+
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""
34+
35+
connection_name: Optional[str] = None
36+
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """
3437

3538
account: Optional[str] = None
3639
""" Snowflake deployment identifier -- drop .snowflakecomputing.com """

sdk/python/feast/infra/registry/snowflake.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,10 @@ class SnowflakeRegistryConfig(RegistryConfig):
8080
""" Registry type selector """
8181

8282
config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
83-
""" Snowflake config path -- absolute path required (Cant use ~) """
83+
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""
84+
85+
connection_name: Optional[str] = None
86+
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """
8487

8588
account: Optional[str] = None
8689
""" Snowflake deployment identifier -- drop .snowflakecomputing.com """

0 commit comments

Comments
 (0)