Skip to content

Minor fixes in variables, locals, r53 zone etc #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 19, 2021
Merged

Minor fixes in variables, locals, r53 zone etc #31

merged 17 commits into from
Apr 19, 2021

Conversation

halfb00t
Copy link
Member

@halfb00t halfb00t commented Apr 16, 2021 •
edited
Loading

Changes

  • Added README.md files to the layers using terraform-docs
  • Removed some critical values from variables.tf, added missing descriptions
  • Created example tfvars in layer1
  • Removed parameter store tf file for secrets, made sm secret to store secret values
  • removed backend.tf files, added them to gitignore
  • removed state bucket name from terragrunt.hcl
  • Added r53 module to create zone if necessary
  • Added default role to eks module for authmap with the ability to add additional roles using eks_map_roles variable
  • Fixed grafana helm chart repo for loki stack
  • Fixed domain names for promstack
  • Made loki datasource enabled by deault in grafana tmplate
  • Removed inaccessible dashboards from grafana template
  • Updated readme files
    Closes Clean up hardcoded values in variables.tf, backend.tf #26
    Closes Grafana dashboard downloads #32

halfb00t added 13 commits April 9, 2021 14:52
@guardrails
Copy link

guardrails bot commented Apr 16, 2021 •
edited
Loading

⚠️ We detected 1 security issue in this pull request:

Hard-Coded Secrets (1)

aws-eks-base/terraform/layer2-k8s/variables.tf

Line 100 in fcb45ce

default = "6.3.0"

More info on how to fix Hard-Coded Secrets in Terraform.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@halfb00t halfb00t changed the title Cle Minor fixes in variables, locals, r53 zone etc Apr 17, 2021
@halfb00t halfb00t mentioned this pull request Apr 19, 2021
Closed
@halfb00t halfb00t merged commit 78aa2df into main Apr 19, 2021
@halfb00t halfb00t deleted the feature/variables-cleanup branch April 19, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@mglotov mglotov mglotov approved these changes

@khalezin khalezin khalezin approved these changes

@cybertester cybertester Awaiting requested review from cybertester

@ilten ilten Awaiting requested review from ilten

@Kirill-Kulikov Kirill-Kulikov Awaiting requested review from Kirill-Kulikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grafana dashboard downloads Clean up hardcoded values in variables.tf, backend.tf
4 participants
@halfb00t @p1gmale0n @mglotov @khalezin