Skip to content

Commit 2adb6e2

Browse files
Merge pull request #552 from magento-south/public-pr
Bugs - MAGETWO-60004 [GITHUB] Fix error with the WYSIWYG and Greek characters #5548 - MAGETWO-57857 [GITHUB] Fix runner for JsTestDriver based tests on OS X #5045 - MAGETWO-56789 [GITHUB][PR] block newsletter title #4958
2 parents 8bde202 + 2036fd5 commit 2adb6e2

File tree

3 files changed

+26
-17
lines changed

3 files changed

+26
-17
lines changed

app/code/Magento/Newsletter/view/frontend/templates/subscribe.phtml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
?>
1212
<div class="block newsletter">
13-
<div class="title"><strong>Newsletter</strong></div>
13+
<div class="title"><strong><?php /* @escapeNotVerified */ echo __('Newsletter') ?></strong></div>
1414
<div class="content">
1515
<form class="form subscribe"
1616
novalidate

dev/tests/js/JsTestDriver/run_js_tests.php

+24-16
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
} else {
3131
if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
3232
$browser = 'C:\Program Files (x86)\Mozilla Firefox\firefox.exe';
33+
} elseif (PHP_OS === 'Darwin') {
34+
$browser = '/Applications/Firefox.app/Contents/MacOS/firefox';
3335
} else {
3436
$browser = exec('which firefox');
3537
}
@@ -139,29 +141,35 @@
139141
kill -9 $LSOF
140142
fi
141143
142-
DISPLAY_NUM=99
143-
ps -ef | egrep "[X]vfb.*:$DISPLAY_NUM"
144-
if [ $? -eq 0 ] ; then
145-
pkill Xvfb
144+
# Skip Xvfb setup for OS X since there browsers do not support headless display that way
145+
if [ "$(uname)" != "Darwin" ]; then
146+
DISPLAY_NUM=99
147+
ps -ef | egrep "[X]vfb.*:$DISPLAY_NUM"
148+
if [ $? -eq 0 ] ; then
149+
pkill Xvfb
150+
fi
151+
152+
XVFB=`which Xvfb`
153+
if [ "$?" -eq 1 ];
154+
then
155+
echo "Xvfb not found."
156+
exit 1
157+
fi
158+
159+
$XVFB :$DISPLAY_NUM -nolisten inet6 -ac &
160+
PID_XVFB="$!" # take the process ID
161+
export DISPLAY=:$DISPLAY_NUM # set display to use that of the Xvfb
146162
fi
147-
148-
XVFB=`which Xvfb`
149-
if [ "$?" -eq 1 ];
150-
then
151-
echo "Xvfb not found."
152-
exit 1
153-
fi
154-
155-
$XVFB :$DISPLAY_NUM -nolisten inet6 -ac &
156-
PID_XVFB="$!" # take the process ID
157-
export DISPLAY=:$DISPLAY_NUM # set display to use that of the Xvfb
163+
158164
USER=`whoami`
159165
SUDO=`which sudo`
160166
161167
# run the tests
162168
$SUDO -u $USER ' . $command . '
163169
164-
kill -9 $PID_XVFB # shut down Xvfb (firefox will shut down cleanly by JsTestDriver)
170+
if [ "$(uname)" != "Darwin" ]; then
171+
kill -9 $PID_XVFB # shut down Xvfb (firefox will shut down cleanly by JsTestDriver)
172+
fi
165173
echo "Done."';
166174

167175
fwrite($fh, $shellCommand . PHP_EOL);

lib/web/mage/adminhtml/wysiwyg/tiny_mce/setup.js

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ define([
8282
}
8383

8484
var settings = {
85+
entity_encoding: 'raw',
8586
mode: (mode != undefined ? mode : 'none'),
8687
elements: this.id,
8788
theme: 'advanced',

0 commit comments

Comments
 (0)