Skip to content

Commit 439cb8c

Browse files
committed
MAGETWO-32341: [GITHUB] Configurable product attribute scope #866
- Remove attribute's 'is_configurable' property usage from javascript - Remove 'is_configurable' property from ProductAttributeDataBuilder
1 parent fded197 commit 439cb8c

File tree

5 files changed

+1
-63
lines changed

5 files changed

+1
-63
lines changed

app/code/Magento/Catalog/Api/Data/ProductAttributeDataBuilder.php

-10
Original file line numberDiff line numberDiff line change
@@ -118,16 +118,6 @@ public function setApplyTo($applyTo)
118118
return $this;
119119
}
120120

121-
/**
122-
* @param string|null $isConfigurable
123-
* @return $this
124-
*/
125-
public function setIsConfigurable($isConfigurable)
126-
{
127-
$this->_set('is_configurable', $isConfigurable);
128-
return $this;
129-
}
130-
131121
/**
132122
* @param string|null $isSearchable
133123
* @return $this

app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config.php

-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ protected function _prepareLayout()
190190
'attribute' => [
191191
'is_global' => 1,
192192
'frontend_input' => 'select',
193-
'is_configurable' => 1,
194193
],
195194
]
196195
]

app/code/Magento/ConfigurableProduct/view/adminhtml/layout/catalog_product_attribute_edit.xml

-14
This file was deleted.

app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/attribute/js.phtml

-38
This file was deleted.

dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php

+1
Original file line numberDiff line numberDiff line change
@@ -2040,4 +2040,5 @@
20402040
['getResultCollection', 'Magento\CatalogSearch\Model\Resource\EngineInterface'],
20412041
['getAdvancedResultCollection', 'Magento\CatalogSearch\Model\Resource\EngineInterface'],
20422042
['getEntityTypeId', 'Magento\Customer\Model\Customer'],
2043+
['setIsConfigurable', 'Magento\Catalog\Api\Data\ProductAttributeDataBuilder'],
20432044
];

0 commit comments

Comments
 (0)