Skip to content

Commit 8bcd2fa

Browse files
committed
Refactor: remove redundant check
1 parent 7bd5e25 commit 8bcd2fa

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGenerator.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,11 @@ protected function generateForGlobalScope(
124124
$mergeDataProvider = clone $this->mergeDataProviderPrototype;
125125
$categoryId = $category->getId();
126126
foreach ($category->getStoreIds() as $storeId) {
127-
if ($storeId !== Store::DEFAULT_STORE_ID) {
128-
$category = clone $category; // prevent undesired side effects on original object
129-
}
130-
$category->setStoreId($storeId);
131127
if (!$this->isGlobalScope($storeId)
132128
&& $this->isOverrideUrlsForStore($storeId, $categoryId, $overrideStoreUrls)
133129
) {
130+
$category = clone $category; // prevent undesired side effects on original object
131+
$category->setStoreId($storeId);
134132
$this->updateCategoryUrlForStore($storeId, $category);
135133
$mergeDataProvider->merge($this->generateForSpecificStoreView($storeId, $category, $rootCategoryId));
136134
}

0 commit comments

Comments
 (0)