Multiple newsletter confirmation emails sent

[nfourteen]

Preconditions

1. Magento 2.2.1
2. Php 7.0

Steps to reproduce

1. Change configuration under Stores > Configuration > Customers > Newsletter > Subscription Options > Need to Confirm to Yes
2. Sign up for Newsletter on frontend as a guest
3. Follow confirmation link in email
4. Create an account and check Sign Up for Newsletter within the form and use the same email as in Step 2

Expected result

There are a couple different results that I'll leave to the Magento core team:

1. If someone signed up for a Newsletter subscription as a guest, have confirmed that subscription, and then create an account with the same email—then the Magento application could update the Newsletter Subscribers with the customer data and leave the status as Subscribed, thus no Need to Confirm email is sent since they've already confirmed they wanted to receive the newsletter.
2. The Magento application could change the guest email status to STATUS_UNCONFIRMED, update the guest email with the customer data, and send the Need to Confirm email for the new account.

Actual result

1. Three Need to Confirm emails are received.

Reason

The first two emails are received because of the \Magento\Newsletter\Model\Plugin\CustomerPlugin::afterSave() method. When \Magento\Customer\Controller\Account\CreatePost::execute() is called a new customer account is created on line 313 with \Magento\Customer\Model\AccountManagement::createAccount(). The createAccount() method calls createAccountWithPasswordHash() whereby the customer is saved on line 748 and then that same method calls $this->changeResetPasswordLinkToken() on line 775, which again saves the customer on line 1242. Thus these two customer saves trigger the afterSave() method calls on the CustomerPlugin, which updates the subscription and sends the two emails.

The third and final email is received within the Magento\Customer\Controller\Account\CreatePost::execute() method on line 317 when the is_subscribed param is retrieved from the form data within the request and the if conditional equals true because of Step 4 above.

[magento-engcom-team]

@nfourteen, thank you for your report.
We've created internal ticket(s) MAGETWO-85994 to track progress on the issue.

[matthiashamacher]

Hello,
We have a similar issue with the newsletter.
When the customer wants a new password (Forgot Your Password?) and when he changes his password after clicking the link in the reset E-Mail, he must confirm the newsletter another time. The confirmed newsletter subscriptions were unsubscripted.
A workaround for this is to deactivate the function "Need to Confirm".

[serhii-balko]

Hi @matthiashama
My pull request may be fix it.

[matthiashamacher]

Hi @serhii-balko
Are you still work on it? Or where do I find your pull request?

[serhii-balko]

Yes, it will be merged after a while
https://github.com/magento-engcom/magento2ce/pull/1139

[torhoehn]

@serhii-balko You created a pull request to a private repository. You should create your pull request for this public repository and inside of your PR you should mention this issue. So it'll be linked automatically.

[magento-team]

Hi @nfourteen. Thank you for your report.
The issue has been fixed in #13044 by @torhoehn in 2.2-develop branch
Related commit(s):

• 9ab75ba
• 93453a8

The fix will be available with the upcoming patch release.

[magento-engcom-team]

Hi @nfourteen. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1351 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• 70dd5a3
• 54bc3a1
• 3debd3f
• 72c4965
• e60ecdf
• 8703b3d
• bd88ed8
• 1c70b18
• 5fd7481
• 7c61506
• 2653b8a
• 917a03f
• eca73d0
• 26f3109
• c223484
• 3b90ad7
• ad317c2
• 53e721c
• 6114120
• 63b4839

The fix will be available with the upcoming 2.3.0 release.