Skip to content

On checkout page coupon code validation message break when enter coupon like "test/" #21353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mageprince opened this issue Feb 20, 2019 · 30 comments
Assignees
Labels
Area: Frontend Component: Checkout Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Ready for Triage Issue is ready to me triaged with Product Manager

Comments

@mageprince
Copy link
Contributor

mageprince commented Feb 20, 2019

Preconditions (*)

  1. Magento 2.3.x

Steps to reproduce (*)

  1. Create a new Cart Price Rule from Admin > Marketing > Cart Price Rule

  2. Select the next setting and value
    -- Coupon = Specific Coupon
    -- Coupon Code = test/

  3. Go to Storefront as Guest or Registered user

  4. Add test product to Shopping Cart

  5. Go to Shopping Cart page

  6. Click "Apply Discount Code" and apply coupon "test/" (Discount Code is applied successfully)
    Screenshot from 2020-08-05 17-56-44

  7. Click "Apply Discount Code" again and "Cancel Coupon"

  8. Proceed to Checkout now(without cupon)

  9. Fill all required information for Shipping Address steps and go NEXT

  10. On Payment Method steps, Click "Apply Discount Code" and apply coupon "test/"

Expected result (*)

  • The coupon "test/" is successfully applied in the same way as from the Shopping Cart page

Actual result (*)

Screenshot from 2020-08-05 17-57-36

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 20, 2019

Hi @mageprince. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@mageprince do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 20, 2019
@krishprakash krishprakash self-assigned this Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 20, 2019

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Area: Frontend Component: Checkout labels Feb 20, 2019
@krishprakash
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-21353-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release bug report labels Feb 20, 2019
@ghost ghost removed the bug report label Feb 20, 2019
@shikhamis11 shikhamis11 self-assigned this Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 20, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11 shikhamis11 added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Feb 20, 2019
@shikhamis11
Copy link
Member

shikhamis11 commented Feb 20, 2019

also at backend it is allowed to create coupon code like test/ . Coupon is being applied from checkout cart page but not from payment step

@shikhamis11 shikhamis11 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 20, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98339, MAGETWO-98340 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@Shubham0492
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul, here is your Magento instance.
Admin access: https://i-21353-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost assigned mageprince and unassigned mageprince Jun 26, 2019
@josefbehr
Copy link
Contributor

@shikhamis11 So, we can create coupons that contain or end in "/" in the backend, but then not apply them in the frontend? Then we should fix the application of code, or completely block creation of such coupons.

@josefbehr josefbehr self-assigned this Aug 13, 2019
@Bartlomiejsz
Copy link
Contributor

@magento-engcom-team @ihor-sviziev seems the issue is solved on 2.4-develop:
image

@ihor-sviziev
Copy link
Contributor

Hi @shikhamis11 could you confirm that issue is fixed and close the issue?

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.4-develop instance

@shikhamis11
Copy link
Member

Hi @ihor-sviziev I checked as per explanation of @sdzhepa coupon code with / is valid and it should be working at every place at checkout as well as on shopping cart ..
I checked on magento 2.4-develop instance It seems working at checkout cart page but not on checkout page .. so this issue persist at magento 2.4-develop instance also

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 20, 2020

@shikhamis11 thank you!

@Bartlomiejsz looks like this issue still there

@Bartlomiejsz
Copy link
Contributor

Bartlomiejsz commented Feb 20, 2020

@ihor-sviziev @shikhamis11 that's weird, you can see on image attached in my previous comment that on my local which is clean fork of 2.4-develop this request was finished successfully and coupon code was added. On github test instance it ends with 404. If I'll be able to I'll try to verify what can be a difference here somewhere in future

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 20, 2020

@Bartlomiejsz It might be related to apache vs nginx configuration.
On test instances we have apache and seems like it is configure incorrectly.

I think it might be related to following:
#13343 (comment)
#8615 (comment)

@Bartlomiejsz
Copy link
Contributor

Definitely looks like it @ihor-sviziev, I'm using nginx locally, so setting AllowEncodedSlashes should fix this for apache I think 👍

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 20, 2020

Hi @slavvka @sidolov @lenaorobei @naydav,
Could you help to resolve incorrect Apache configuration of test instances?

@Bartlomiejsz in addition to that I reported issue to describe needed configuration in the devdocs magento/devdocs#6689

@ihor-sviziev ihor-sviziev self-assigned this Feb 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2020

Hi @ihor-sviziev. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@magento magento deleted a comment from magento-deployment-service bot Mar 4, 2020
@nwmagento
Copy link

@magento-engcom-team give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento magento deleted a comment from magento-deployment-service bot Mar 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @nwmagento, here is your Magento instance.
Admin access: https://i-21353-2-4-develop.instances.magento-community.engineering/admin_ebfd
Login: d30578be Password: 06cde9c69b47
Instance will be terminated in up to 3 hours.

@engcom-Alfa engcom-Alfa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 5, 2020
@ihor-sviziev
Copy link
Contributor

Hi @mageprince,
I'm closing this issue as the issue was in the web server configuration. This info was added to dev docs:
https://devdocs.magento.com/guides/v2.3/install-gde/prereq/apache.html#apache-required-directives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Checkout Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Ready for Triage Issue is ready to me triaged with Product Manager
Projects
None yet
Development

No branches or pull requests