From afafa4029bcb33e215a967686c03a57d1316f30c Mon Sep 17 00:00:00 2001 From: fxhuhn Date: Tue, 25 May 2021 18:19:22 +0200 Subject: [PATCH 1/3] adding edgecolors and linewidths --- src/mplfinance/plotting.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mplfinance/plotting.py b/src/mplfinance/plotting.py index c6cccc0b..3d497de4 100644 --- a/src/mplfinance/plotting.py +++ b/src/mplfinance/plotting.py @@ -908,10 +908,13 @@ def _addplot_columns(panid,panels,ydata,apdict,xdates,config): mark = apdict['marker'] color = apdict['color'] alpha = apdict['alpha'] + edgecolors = apdict['edgecolors'] + linewidths = apdict['linewidths'] + if isinstance(mark,(list,tuple,np.ndarray)): _mscatter(xdates,ydata,ax=ax,m=mark,s=size,color=color,alpha=alpha) else: - ax.scatter(xdates,ydata,s=size,marker=mark,color=color,alpha=alpha) + ax.scatter(xdates, ydata, s=size, marker=mark, color=color, alpha=alpha, edgecolors=edgecolors, linewidths=linewidths) elif aptype == 'bar': width = 0.8 if apdict['width'] is None else apdict['width'] bottom = apdict['bottom'] @@ -1026,6 +1029,7 @@ def _valid_addplot_kwargs(): valid_linestyles = ('-','solid','--','dashed','-.','dashdot','.','dotted',None,' ','') valid_types = ('line','scatter','bar', 'ohlc', 'candle','step') valid_stepwheres = ('pre','post','mid') + valid_edgecolors = ('face', 'none', None) vkwargs = { 'scatter' : { 'Default' : False, @@ -1053,7 +1057,13 @@ def _valid_addplot_kwargs(): 'linestyle' : { 'Default' : None, 'Validator' : lambda value: value in valid_linestyles }, - 'width' : { 'Default' : None, # width of `bar` or `line` + 'linewidths': {'Default': None, + 'Validator' : lambda value: isinstance(value,(int,float)) }, + + 'edgecolors': {'Default': None, + 'Validator': lambda value: mcolors.is_color_like(value) or value in valid_edgecolors}, + + 'width' : { 'Default' : None, # width of `bar` or `line` 'Validator' : lambda value: isinstance(value,(int,float)) or all([isinstance(v,(int,float)) for v in value]) }, From a0c9aceb87a57bd30eddad193de6045a940576ff Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Tue, 14 Dec 2021 13:57:59 -0500 Subject: [PATCH 2/3] add edgecolors and linewidths to _mscatter() --- src/mplfinance/plotting.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mplfinance/plotting.py b/src/mplfinance/plotting.py index 6b2a857a..eb61b469 100644 --- a/src/mplfinance/plotting.py +++ b/src/mplfinance/plotting.py @@ -919,7 +919,7 @@ def _addplot_columns(panid,panels,ydata,apdict,xdates,config): linewidths = apdict['linewidths'] if isinstance(mark,(list,tuple,np.ndarray)): - _mscatter(xdates,ydata,ax=ax,m=mark,s=size,color=color,alpha=alpha) + _mscatter(xdates, ydata, ax=ax, m=mark, s=size, color=color, alpha=alpha, edgecolors=edgecolors, linewidths=linewidths) else: ax.scatter(xdates, ydata, s=size, marker=mark, color=color, alpha=alpha, edgecolors=edgecolors, linewidths=linewidths) elif aptype == 'bar': From f17324b1aa9681763ec86cd28e32bc5330cb18e6 Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Tue, 14 Dec 2021 14:00:00 -0500 Subject: [PATCH 3/3] bump version --- src/mplfinance/_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mplfinance/_version.py b/src/mplfinance/_version.py index 8a17c325..1d141451 100644 --- a/src/mplfinance/_version.py +++ b/src/mplfinance/_version.py @@ -1,5 +1,5 @@ -version_info = (0, 12, 8, 'beta', 4) +version_info = (0, 12, 8, 'beta', 5) _specifier_ = {'alpha': 'a','beta': 'b','candidate': 'rc','final': ''}