Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

prometheus.Handler() is deprecated, figure out how to replace it #243

Closed
erikjohnston opened this issue Sep 20, 2017 · 4 comments
Closed

Comments

@erikjohnston
Copy link
Member

No description provided.

@t3chguy
Copy link
Member

t3chguy commented Nov 19, 2017

as far as I am aware this is just a straight s/prometheus.Handler()/promhttp.Handler()
that's how matrix-static's prom works anyway

Uninstrumented vs Instrumented

:L

@erikjohnston
Copy link
Member Author

Ah, yes.

For the record: prometheus.Handler automatically includes a bunch of useful metrics (apparently), whereas promhttp.Handler doesn't. We can recreate a lot of it with the helper functions in promhttp, but we need to figure out what stats we want

@t3chguy
Copy link
Member

t3chguy commented Nov 20, 2017

I wonder if matrix-static is missing a load of useful metrics, I don't believe it is though when I checked locally
(/me has no access to your Prom instance)

@kegsay
Copy link
Member

kegsay commented Aug 26, 2020

We use promhttp now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants