possible data race

[kevinburke]

From golang/go#18429:

On a side note, sqlite3 might also have a data race where sqliteConn.Close doesn't check if the sqliteStmt.exec is still running the goroutine.

Here's the stack trace:

WARNING: DATA RACE
Read at 0x00c420095810 by goroutine 2118:
  github.com/mattn/go-sqlite3.(*SQLiteStmt).exec.func3()
      /home/daniel/src/github.com/mattn/go-sqlite3/sqlite3.go:814 +0xef

Previous write at 0x00c420095810 by goroutine 312:
  github.com/mattn/go-sqlite3.(*SQLiteConn).Close()
      /home/daniel/src/github.com/mattn/go-sqlite3/sqlite3.go:633 +0x7b
  database/sql.(*driverConn).finalClose.func2()
      /home/daniel/code/go-cl/src/database/sql/sql.go:439 +0x8c
  database/sql.withLock()
      /home/daniel/code/go-cl/src/database/sql/sql.go:2452 +0x76
  database/sql.(*driverConn).finalClose()
      /home/daniel/code/go-cl/src/database/sql/sql.go:441 +0x1d0
  database/sql.(finalCloser).(database/sql.finalClose)-fm()
      /home/daniel/code/go-cl/src/database/sql/sql.go:536 +0x46
  database/sql.(*driverConn).Close()
      /home/daniel/code/go-cl/src/database/sql/sql.go:418 +0x1ee
  database/sql.(*DB).putConn()
      /home/daniel/code/go-cl/src/database/sql/sql.go:1016 +0x2d0
  database/sql.(*Tx).close()
      /home/daniel/code/go-cl/src/database/sql/sql.go:1428 +0xb7
  database/sql.(*Tx).rollback()
      /home/daniel/code/go-cl/src/database/sql/sql.go:1497 +0x14d
  database/sql.(*DB).begin.func2()
      /home/daniel/code/go-cl/src/database/sql/sql.go:1366 +0xb8

(I'm just passing this along; I don't know how to repro it)

[mattn]

should fix race condition.

Could you please try this 6f2749a ?

[yonderblue]

Isn't there another one around line 769?

[mattn]

No

[mattn]

Ah, I just notice you said. Thanks.