Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): disable broken autofocus in SO cond. price form #11944

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

SteelRazor47
Copy link

What

  • Disabled auto-focus on the currency input component in the form to edit conditional prices for shipping options

Why

  • Currently there is an autofocus loop, on Firefox only, between the currency input and modal close button elements. This prevents firefox users from typing in a price until the loop is broken(e.g. by clicking on the browser navbar or devtools), see [Bug]: Input Component Text Always Highlighted, Blocking Price Entry (ServiceZone -> Conditional Price Component) #11470.
  • The auto-focus on the currency input doesn't work regardless on other browsers, the close button for the modal is focused instead when opening the stacked modal. See screenshot. Since it doesn't work on other browsers i think it's best to disable it entirely

Edge:
edge

@SteelRazor47 SteelRazor47 requested a review from a team as a code owner March 22, 2025 14:50
Copy link

changeset-bot bot commented Mar 22, 2025

⚠️ No Changeset found

Latest commit: ace30dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 22, 2025

@SteelRazor47 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant