Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on MacOS #107

Open
IsaacBreen opened this issue Nov 17, 2022 · 1 comment
Open

Unable to build on MacOS #107

IsaacBreen opened this issue Nov 17, 2022 · 1 comment

Comments

@IsaacBreen
Copy link
Contributor

IsaacBreen commented Nov 17, 2022

I was only able to build on MacOS after removing the following lines from ./CMakeLists.txt and ./samples/CMakeLists.txt:

elseif (UNIX AND APPLE)
    link_libraries("framework")

It may be worth noting that, contrary to the docs, this works regardless of whether I use SDL2.framework (installed at /Library/Frameworks) or the homebrew version.

I'm submitting this as an issue rather than a pull request because I don't yet understand Tilengine well enough to:

  1. understand what purpose these lines serve
  2. know whether they're still required
  3. ensure removing them won't break something (I've tried a few of the samples; they seem to run fine)

Happy to make a PR if needed.

@megamarc
Copy link
Owner

Hi!

These CMake support files were contributed by github user Aleksei @lxxxxl , I don't really know the exact inner working. However removing these lines shouldn't harm the rest of configurations, as it only affects MacOS. You can remove them and make a PR if you know the effect of doing it, as I can't validate it.

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants