Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode character set not supported? #3213

Closed
huyz opened this issue Jun 13, 2022 · 4 comments
Closed

Unicode character set not supported? #3213

huyz opened this issue Jun 13, 2022 · 4 comments
Labels
Internals: Parser Retained Nonperishable Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@huyz
Copy link

huyz commented Jun 13, 2022 •
edited by knsv
Loading

Describe the bug
Some Unicode characters don't seem to be supported, in particular emojis.

To Reproduce
Link to Live Editor: https://mermaid.live/edit#pako:eNpVkE1Ow0AMha9ieQVSc4EskGhSuqkEEt1lurASpzOi86OJI1QlOQRnYMeKPUsQ9-AmTFqQwCvL73vPsgesfcOY4z5S0LAtlYNU11Who-nEUreDLLsa1yxgvePjCMuLtYdO-xCM21-e-eUMQTG8v8DH0-fr19tzDbCZPQyijXuYzlxxCrt1PEJZbSiID7u_yvbRj7CqzJ1Ou_4rOnJy3VQt5S1lNUUoKJ4QXKDlaMk06Y5hnigUzZYV5qltuKX-IAqVmxLah4aEV40RHzFFHTpeIPXi74-uxlxiz79QaSi9xf5Q0zcyL2QX

Steps to reproduce the behavior:

  1. Go to https://mermaid.live/edit
  2. Click on text editor where it says "Let me think"
  3. Add emojis like: 🛫 ✅
  4. Notice that the rendering has stopped updating and the emojis don't show up

Expected behavior
I would expect emojis to be rendered.

Screenshots
screenshot 2022-06-13T083313Z

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Brave
  • Version: 1.39.111
    The same issue affects words containing arabic diacritics such as: عَرَبِي
@huyz huyz added the bug label Jun 13, 2022
@sidharthv96 sidharthv96 added the Retained Nonperishable label Jun 16, 2022
@sidharthv96 sidharthv96 self-assigned this Jun 16, 2022
@sidharthv96 sidharthv96 removed their assignment Jul 8, 2022
@sidharthv96
Copy link
Member

This seems to be an issue with jison not being able to parse the emojis.

@sidharthv96 sidharthv96 transferred this issue from mermaid-js/mermaid-live-editor Jul 8, 2022
@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Jul 8, 2022
@knsv knsv mentioned this issue Aug 21, 2022
Closed
@sidharthv96 sidharthv96 mentioned this issue Sep 8, 2022
Closed
3 tasks
@jgreywolf jgreywolf added Type: Bug / Error Something isn't working or is incorrect and removed bug labels Jan 26, 2023
@xxorde
Copy link

xxorde commented Apr 14, 2023

This bothers me as well, would love to see a fix!

@xxorde
Copy link

xxorde commented Apr 14, 2023 •
edited
Loading

When the HTML representation is used, it fails differently. The UTF8 character is at least displayed correctly in the error message. 😎

Screenshot from 2023-04-14 11-02-32

A[Christmas 🎄]

@sidharthv96
Copy link
Member

image image

Both examples are working now.
Please use double quotes "Label 🛫 ✅" to support unicode and emojis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internals: Parser Retained Nonperishable Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@huyz @jgreywolf @xxorde @sidharthv96 @Yokozuna59