[PT Run] Calculator interprets comma used as number separator as decimal separator

[htcfreek]

Microsoft PowerToys version

0.56.2

Running as admin

• Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Typing max(1,2).

✔️ Expected Behavior

Expected result: 2 as this is the highest number.

❌ Actual Behavior

Actual result: 1.2 (1,2) because in Germany we use , as decimal separator.

For example pow work only if I have at least three numbers like pow(3,3,3).

Other Software

No response

[jaimecbernardo]

Unfortunately, something that can be done so that the number isn't interpreted together is separating the commas from function calling by spaces, like max(1 , 2). Unfortunately, doing number translation between cultures is tricky. Perhaps what we can do here is add an option so that we don't try to accept culture translated numbers?

[htcfreek]

what about using ; instead of , to separate numbers?

[jaimecbernardo]

Perhaps doing a pass where we'd convert ; to, before sending it to mages? After we do the translation? I don't know if there are cultures where ; may be used as a decimal or thousands separator, though.

[htcfreek]

Perhaps doing a pass where we'd convert ; to, before sending it to mages? After we do the translation?

That's my idea.

I don't know if there are cultures where ; may be used as a decimal or thousands separator, though.

Don't think so. Let's ask google. 😂

[htcfreek]

https://en.m.wikipedia.org/wiki/Decimal_separator says only comma or dot is used per standard

[htcfreek]

do you think this should be a setting?

[jaimecbernardo]

It could be a setting, turned off by default.

[Jay-o-Way]

do you think this should be a setting?

I don't.

[jaimecbernardo]

The settings would be about converting intput from culture and then another one to convert output to culture, as discussed here: #17381

[htcfreek]

@jaimecbernardo
Should I reverting #16980 when I implement the two new settings?

[jaimecbernardo]

@jaimecbernardo Should I reverting #16980 when I implement the two new settings?

I wonder. I think people will still expect the calculator to take "." 🤷
Setting for "always interpret "." as a decimal point"? 😅

This sounds like so many settings though.

[htcfreek]

@jaimecbernardo Should I reverting #16980 when I implement the two new settings?

I wonder. I think people will still expect the calculator to take "." 🤷
Setting for "always interpret "." as a decimal point"? 😅

This sounds like so many settings though.

I thought on two settings without some combinations of dot and comma:

• "Use english format for input instead of your local one."
• "Use english format for output instead of your local one."

We can add an example input and output to the description of the settings.

I am from Germany and wonder how the input with local format has to be. 😅

[jaimecbernardo]

Sounds good. I think we won't even need to run "translation" functions in that case, since Mages already works with the English format. (Wonder if english-US should be specified)

[htcfreek]

@Jay-o-Way
If you react with a thumbs down emoji please explain what you don't like.

[Jay-o-Way]

I'm not a fan of so many settings. But that's personal.

[htcfreek]

Released with 0.59.0