Skip to content

Can't use elementToAppend when embedding sandbox #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codetheweb opened this issue Jul 13, 2023 · 0 comments · Fixed by #2886
Closed

Can't use elementToAppend when embedding sandbox #2885

codetheweb opened this issue Jul 13, 2023 · 0 comments · Fixed by #2886

Comments

@codetheweb
Copy link
Contributor

codetheweb commented Jul 13, 2023 •
edited
Loading

Because domID in the sandbox config takes precedence over elementToAppend:

TypeScript-Website/packages/sandbox/src/index.ts

Line 147 in a03790f

const element = "domID" in config ? document.getElementById(config.domID) : (config as any).elementToAppend

and domID is always given a default of "":

TypeScript-Website/packages/sandbox/src/index.ts

Line 89 in a03790f

domID: "",

elementToAppend will never work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make elementToAppend take priority over domID for sandbox configs codetheweb/TypeScript-Website
1 participant
@codetheweb