PR review

MariaSolOs · MariaSolOs · commit 119a2d6379c1 · 2023-09-18T15:35:05.000-07:00
diff --git a/src/services/inlayHints.ts b/src/services/inlayHints.ts
@@ -461,6 +461,7 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {
 
         const parts: InlayHintDisplayPart[] = [];
         visitDisplayPart(typeNode);
+        return parts;
 
         function visitDisplayPart(node: Node) {
             if (!node) {
@@ -736,6 +737,8 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {
                         visitDisplayPart(propertySignature.type);
                     }
                     break;
+                default:
+                    Debug.fail(`Unhandled node kind: ${node.kind}`);
             }
         }
 
@@ -747,8 +750,6 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {
                 visitDisplayPart(node);
             });
         }
-
-        return parts;
     }
 
     function isUndefined(name: __String) {

Original file line number	Diff line number	Diff line change
`@@ -461,6 +461,7 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {`
`461`	`461`
`462`	`462`	`const parts: InlayHintDisplayPart[] = [];`
`463`	`463`	`visitDisplayPart(typeNode);`
	`464`	`+ return parts;`
`464`	`465`
`465`	`466`	`function visitDisplayPart(node: Node) {`
`466`	`467`	`if (!node) {`
`@@ -736,6 +737,8 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {`
`736`	`737`	`visitDisplayPart(propertySignature.type);`
`737`	`738`	`}`
`738`	`739`	`break;`
	`740`	`+ default:`
	`741`	+ Debug.fail(`Unhandled node kind: ${node.kind}`);
`739`	`742`	`}`
`740`	`743`	`}`
`741`	`744`
`@@ -747,8 +750,6 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {`
`747`	`750`	`visitDisplayPart(node);`
`748`	`751`	`});`
`749`	`752`	`}`
`750`		`-`
`751`		`- return parts;`
`752`	`753`	`}`
`753`	`754`
`754`	`755`	`function isUndefined(name: __String) {`