Finish applying no-object-literal-type-assertion lint rule

Author: andy-ms

src/compiler/checker.ts

@@ -1862,8 +1862,10 @@ namespace ts {
                     target.set(id, sourceSymbol);
                     if (lookupTable && exportNode) {
                         lookupTable.set(id, {
-                            specifierText: getTextOfNode(exportNode.moduleSpecifier)
-                        } as ExportCollisionTracker);
+                            specifierText: getTextOfNode(exportNode.moduleSpecifier),
+                            // TODO: GH#18217: (exportsWithDuplicate was not present)
+                            exportsWithDuplicate: undefined,
+                        });
                     }
                 }
                 else if (lookupTable && exportNode && targetSymbol && resolveSymbol(targetSymbol) !== resolveSymbol(sourceSymbol)) {
@@ -6298,18 +6300,20 @@ namespace ts {
         function createTypePredicateFromTypePredicateNode(node: TypePredicateNode): IdentifierTypePredicate | ThisTypePredicate {
             const { parameterName } = node;
             if (parameterName.kind === SyntaxKind.Identifier) {
-                return {
+                const result: IdentifierTypePredicate = {
                     kind: TypePredicateKind.Identifier,
-                    parameterName: parameterName ? parameterName.escapedText : undefined,
+                    parameterName: parameterName ? parameterName.text : undefined,
                     parameterIndex: parameterName ? getTypePredicateParameterIndex((node.parent as SignatureDeclaration).parameters, parameterName) : undefined,
-                    type: getTypeFromTypeNode(node.type)
-                } as IdentifierTypePredicate;
+                    type: getTypeFromTypeNode(node.type),
+                };
+                return result;
             }
             else {
-                return {
+                const result: ThisTypePredicate = {
                     kind: TypePredicateKind.This,
                     type: getTypeFromTypeNode(node.type)
                 };
+                return result;
             }
         }
 

src/compiler/commandLineParser.ts

@@ -907,7 +907,10 @@ namespace ts {
      */
     export function readJsonConfigFile(fileName: string, readFile: (path: string) => string | undefined): JsonSourceFile {
         const textOrDiagnostic = tryReadFile(fileName, readFile);
-        return typeof textOrDiagnostic === "string" ? parseJsonText(fileName, textOrDiagnostic) : <JsonSourceFile>{ parseDiagnostics: [textOrDiagnostic] };
+        return typeof textOrDiagnostic === "string"
+            ? parseJsonText(fileName, textOrDiagnostic)
+            // tslint:disable-next-line no-object-literal-type-assertion (TODO:GH#18217)
+            : <JsonSourceFile>{ parseDiagnostics: [textOrDiagnostic] };
     }
 
     function tryReadFile(fileName: string, readFile: (path: string) => string | undefined): string | Diagnostic {

src/harness/unittests/session.ts

@@ -148,9 +148,9 @@ namespace ts.server {
                     }
                 };
                 session.onMessage(JSON.stringify(setOptionsRequest));
-                assert.deepEqual(
+                assert.deepEqual<CompilerOptions>(
                     session.getProjectService().getCompilerOptionsForInferredProjects(),
-                    <CompilerOptions>{
+                    {
                         module: ModuleKind.System,
                         target: ScriptTarget.ES5,
                         jsx: JsxEmit.React,
@@ -284,7 +284,7 @@ namespace ts.server {
 
                 session.onMessage(JSON.stringify(req));
 
-                expect(lastSent).to.deep.equal(<protocol.ConfigureResponse>{
+                assert.deepEqual<protocol.ConfigureResponse>(lastSent as protocol.ConfigureResponse, {
                     command: CommandNames.Configure,
                     type: "response",
                     success: true,

src/harness/unittests/tsserverProjectSystem.ts

@@ -1039,6 +1039,7 @@ namespace ts.server {
 
             const result = parseJsonText(configFilename, configFileContent);
             if (!result.endOfFileToken) {
+                // tslint:disable-next-line no-object-literal-type-assertion (TODO: GH#18217)
                 result.endOfFileToken = <EndOfFileToken>{ kind: SyntaxKind.EndOfFileToken };
             }
             const errors = result.parseDiagnostics;

src/server/editorServices.ts

@@ -1003,6 +1003,8 @@ namespace ts.server {
                     if (options.plugins && options.plugins.some(p => p.name === globalPluginName)) continue;
 
                     // Provide global: true so plugins can detect why they can't find their config
+                    // TODO: Pluginimport has no `global` property!
+                    // tslint:disable-next-line no-object-literal-type-assertion (TODO: GH#18217)
                     this.enablePlugin({ name: globalPluginName, global: true } as PluginImport, searchPaths);
                 }
             }

src/server/project.ts

@@ -568,7 +568,7 @@ namespace ts.server {
         }
 
         private convertToDiagnosticsWithLinePosition(diagnostics: ReadonlyArray<Diagnostic>, scriptInfo: ScriptInfo): protocol.DiagnosticWithLinePosition[] {
-            return diagnostics.map(d => <protocol.DiagnosticWithLinePosition>{
+            return diagnostics.map<protocol.DiagnosticWithLinePosition>(d => ({
                 message: flattenDiagnosticMessageText(d.messageText, this.host.newLine),
                 start: d.start,
                 length: d.length,
@@ -577,7 +577,7 @@ namespace ts.server {
                 source: d.source,
                 startLocation: scriptInfo && scriptInfo.positionToLineOffset(d.start),
                 endLocation: scriptInfo && scriptInfo.positionToLineOffset(d.start + d.length)
-            });
+            }));
         }
 
         private getDiagnosticsWorker(
@@ -1952,7 +1952,7 @@ namespace ts.server {
             }
         }
 
-        public executeCommand(request: protocol.Request): { response?: any, responseRequired?: boolean } {
+        public executeCommand<T extends protocol.Request>(request: T): { response?: any, responseRequired?: boolean } {
             const handler = this.handlers.get(request.command);
             if (handler) {
                 return this.executeWithRequestId(request.seq, () => handler(request));

src/server/session.ts

@@ -328,12 +328,15 @@ namespace ts.server.typingsInstaller {
             this.installRunCount++;
 
             // send progress event
-            this.sendResponse(<BeginInstallTypes>{
+            const response: BeginInstallTypes = {
                 kind: EventBeginInstallTypes,
                 eventId: requestId,
                 typingsInstallerVersion: ts.version, // qualified explicitly to prevent occasional shadowing
-                projectName: req.projectName
-            });
+                projectName: req.projectName,
+                // TODO: GH#18217 (property was not present)
+                packagesToInstall: undefined
+            };
+            this.sendResponse(response);
 
             const scopedTypings = filteredTypings.map(typingsName);
             this.installTypingsAsync(requestId, scopedTypings, cachePath, ok => {

src/server/typingsInstaller/typingsInstaller.ts

@@ -23,6 +23,7 @@
         "no-inferrable-types": true,
         "no-internal-module": true,
         "no-null-keyword": true,
+        "no-object-literal-type-assertion": true,
         "no-switch-case-fall-through": true,
         "no-trailing-whitespace": [true, "ignore-template-strings"],
         "no-type-assertion-whitespace": true,